Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TwoDCube The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
verseghy-prow
Bot
added
the
approved
calendar_grid_range added `6 - weekday` days to the next month's first day, so the grid ended a day early and events on its last Sunday were missing; when the next month started on a Monday it added six spare days instead. End at the first Monday on or after that day: `(7 - weekday) % 7` days later. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
TwoDCube
force-pushed
the
fix/events-calendar-grid-end
branch
from
September 14, 2026 18:22
8038d30 to
ec6e13d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug recorded by the tests in #246 and #247. Stacked on #247 (base
test/integration), so this is a draft until #246 and #247 merge.Bug
events(year, month)is documented to return the events shown in the month's calendar grid of Monday-to-Sunday weeks.calendar_grid_rangeset the grid's exclusive end to the next month's 1st plus6 - weekdaydays, which was:Fix
End at the first Monday on or after the next month's 1st, which is
(7 - weekday) % 7days later.Tests
calendar_grid_ends_after_the_sunday_of_the_last_weekand the proptestcalendar_grid_covers_whole_weeks_through_the_month_endare no longer ignored. The proptest's saved counterexample (proptest-regressions/utils/date_range.txt) is committed so it is always re-checked.events_include_the_last_day_of_the_calendar_gridis no longer ignored.calendar__events_of_a_month_cover_its_calendar_gridgains event 5 ("Nyílt nap", Sunday 4 October), which is the intended change.cargo clippy --workspace --all-targets -D warningsis clean.CI=true cargo test --workspacepasses against MySQL 8.4 and Redis 6.2.🤖 Generated with Claude Code