Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TwoDCube The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
verseghy-prow
Bot
added
the
approved
…cking For the earliest month chrono can represent, stepping back to the preceding Monday overflowed NaiveDateTime and panicked, so `events` for that month returned HTTP 500. Use checked arithmetic and return None, which the events resolver already reports as "invalid date". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
TwoDCube
force-pushed
the
fix/events-calendar-grid-end
branch
from
September 14, 2026 18:22
8038d30 to
ec6e13d
Compare
TwoDCube
force-pushed
the
fix/calendar-grid-earliest-month
branch
from
September 14, 2026 18:23
3eb6ef2 to
5cd2e0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug recorded by the tests in #246. Stacked on #248 (base
fix/events-calendar-grid-end), because both changecalendar_grid_range. This is a draft until #246, #247 and #248 merge.Bug
For the earliest month chrono can represent,
calendar_grid_rangestepped back to the preceding Monday with uncheckedNaiveDateTimearithmetic. That overflowed and panicked (NaiveDateTime - TimeDelta overflowed), soeventsfor that month returned HTTP 500 instead of a GraphQL error.Fix
Use
checked_sub_signed/checked_add_signedand returnNonewhen the grid would leave chrono's range. Theeventsresolver already turnsNoneinto itsinvalid dateerror.Tests
calendar_grid_does_not_panic_at_the_earliest_representable_monthis no longer ignored.date_ranges_never_paniccoverscalendar_grid_rangeagain.cargo clippy --workspace --all-targets -D warningsis clean.CI=true cargo test --workspacepasses against MySQL 8.4 and Redis 6.2.🤖 Generated with Claude Code