PDB: power distribution board controller and CAN heartbeat - #61
Closed
georgesleen wants to merge 44 commits into
Closed
PDB: power distribution board controller and CAN heartbeat#61georgesleen wants to merge 44 commits into
georgesleen wants to merge 44 commits into
Conversation
Should work? unless I overlooked something or tested it wrong Signed-off-by: alisha1697 <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: alisha1697 <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: alisha1697 <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: alisha1697 <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: alisha1697 <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: alisha1697 <143849351+alisha1697@users.noreply.github.com>
- receives out of range IDs Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
…from base-library dir
Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
Updated CAN_Init to include heartbeat ID and added heartbeat functionality with TIM7. Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
Signed-off-by: Alisha Siddiqui <143849351+alisha1697@users.noreply.github.com>
I2C stuff commented out Delay reduced to 500ms Moving average implemented(circuilar buffer)
Contributor
Author
|
Superseded by #62, which merges this branch together with the other two module branches into a single integration branch. The conflicts between the three (24 between wingsail and rudder, 1 between wingsail and pdb) are resolved there once rather than falling to whichever PR merges last. This PR can stay open for reference, but merging it directly would leave the other two conflicting against |
Contributor
Author
|
Closing in favour of #62, which contains this branch's tip along with the other three module branches. The conflicts between them are resolved once there rather than falling to whichever of these merged last. Nothing is lost: the tip of this branch is an ancestor of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
pdb-working-branchintomain. 41 commits, none previously merged, somaincurrently has no power distribution board code at all.What's in it
pdb-controllerproject: cell voltage and pack temperature monitoring,MPPT board reporting, CAN telemetry
CAN_Initreworked to takea hardware ID parameter
an
int16_tbuffer correctionfdcan-library-testpromoted to a real projectVerification
The pdb board was read back over SWD and its firmware matched against this
branch by string fingerprint. All 29 authored literals recovered from the
board's own code region are present in this branch's sources, including
MPPT BOARD 1/2,TempPack1/2,VC1..VC4_Cumulative,Cell %d voltage is below threshold %0.2fandHAL ERROR CODE: %lu. The onlyunmatched strings are Thumb instruction bytes and libc internals.
Note this is a source-level match, not byte-exact. The flashed image was built
with GNU Tools for STM32 14.3.rel1.20251027; a byte comparison would require
rebuilding with that exact toolchain. Logic-only changes that add no string
literals cannot be detected this way.
Reviewer notes
Diff excluding
Drivers/,Debug/andRelease/is 103 files, all additions.origin/pdb-nvic-resetcarries one commit not in this branch ("Added resetline in error handler"). Decide whether that should land before or after this
merges, since deleting that branch during cleanup would otherwise lose it.
Per the README this needs two sign-offs, one from an ELEC lead.