Repository navigation
fix(examples): give gn-bundle-roundtrip a falsifier that can fail - #408
Merged
Merged
Conversation
The catalog falsifier expected exit 2 for --legacy-rna, but both outcomes of that branch returned 2 (5.x rejects the legacy node, and the legacy node unexpectedly exists), 2 also meant "carrier mesh rewritten", and argparse exits 2 for an unknown flag. The row passed whether or not the contract held, and would have passed with the flag deleted. Each outcome now has its own code: 6 carrier rewritten, 7 legacy node rejected (the catalog expectation), 8 legacy node accepted. The catalog lint now rejects expect_exit 2 for every row, since a usage error can always satisfy it. Closes #349 Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
CI evidence before merge: all checks pass ( 13 pass ). Blender Smoke on PR head: Blender 5.2.2 LTS / Blender 4.5.14 LTS. Summaries (happy path; falsifiers) per leg: 143 passed, 1 skipped, 0 failed;142 passed, 0 skipped, 0 failed;141 passed, 3 skipped, 0 failed;136 passed, 6 skipped, 0 failed; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #349.
Problem
The
gn-bundle-roundtripcatalog falsifier expected exit 2 for--legacy-rna, but exit 2 meant four different things:So the row passed whether or not the contract held, and would have passed even if the flag were deleted.
Change
gn_bundle_roundtrip.py: the carrier-rewritten check moves to 6, the expected legacy-node rejection to 7, and an unexpectedly accepted legacy node to 8.tests/smoke/catalog.json: expects 7.tests/check_smoke_catalog.py:FORBIDDEN_EXITSnow includes 2 (argparse usage). CLAUDE.md § Smoke and the checker docstring are updated to match.Evidence
Proven by live run (
--factory-startup --python-exit-code 1; binary reports 5.2.1 LTS):--legacy-rnaERROR: RuntimeError: Error: Node type GeometryNodeCombineBundle undefined--legacy-rnaX(simulated deleted flag)error: unrecognized arguments: --legacy-rnaXThe old row (
expect_exit: 2) would have accepted that last line.Lint falsified: with the catalog row set back to
expect_exit: 2,python tests/check_smoke_catalog.pyprints::error::catalog row 'gn-bundle-roundtrip' falsifier 0: expect_exit 2 must be an int other than 0, 1, 2, 77and exits 1. Restored, it passes.Not run locally:
check_exit_code_readme.py,check_falsifier_targets.pyandcheck_smoke_catalog.pypass.🤖 Generated with Claude Code