Repository navigation
docs(examples): stop READMEs saying smoke skips the flag CI runs as the falsifier - #415
Merged
Merged
Conversation
…he falsifier Since falsifiers started running in CI (#320), 57 example READMEs still said "Smoke does not pass `--x`" for the very flag the catalog runs as that example's falsifier, and bmesh-gear (the anatomy every new example copies) was one of them. The line now names only the flags smoke really skips and states the catalog falsifier with its expected exit, matching the four READMEs that already did. check_smoke_catalog.py now fails when a README's "does not pass" clause names its own row's falsifier flag, so the drift cannot return. Closes #359 Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
CI evidence before merge: all checks pass ( 13 pass ). Blender Smoke on PR head: Blender 5.2.2 LTS / Blender 4.5.14 LTS. Summaries (happy path; falsifiers) per leg: 143 passed, 1 skipped, 0 failed;142 passed, 0 skipped, 0 failed;141 passed, 3 skipped, 0 failed;136 passed, 6 skipped, 0 failed; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #359.
Problem
Since falsifiers started running in CI (#320), 57 example READMEs still said "Smoke does not pass
--x" for the very flagtests/smoke/catalog.jsonruns as that example's falsifier.bmesh-gear, the anatomy file every new example copies, was one of them.Change
54 READMEs were rewritten by a script, plus 2 by hand (
gn-modifier-inputs,sky-texture-sun-elevation);gn-bundle-roundtripwas already fixed in fix(examples): give gn-bundle-roundtrip a falsifier that can fail #408. The line now:Its catalog falsifier is--x(expects exit N).;min_version.This matches the four READMEs that were already correct.
tests/check_smoke_catalog.py: a newcheck_readme_claims()fails when a README's "does not pass" clause names its own row's falsifier flag. Validate already runs this script.Example:
Evidence (local, Python 3.13; no Blender needed)
gn-bundle-roundtripline still on this branch), the new check printed::error::examples/gn-bundle-roundtrip/README.md: says smoke does not pass --legacy-rna, but it is this row's catalog falsifierand exited 1. After rebasing ontomain, it passes.check_exit_code_readme.pypasses.🤖 Generated with Claude Code