Repository navigation
Audit README disclosed-services list against actual dependencies - #32
Merged
Merged
Conversation
…json The list only named planned SDKs (@qvac/sdk, WDK, Hyperswarm) tracked by open integration issues, while the build/UI tooling actually installed today (React, Vite, TypeScript, Vitest) wasn't disclosed at all. Per the hackathon rules an omitted base disqualifies the entry, so split the list into "planned" vs. "already in package.json" and account for both. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 56 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "Disclosed external services / third-party components" section only listed planned on-device SDKs (
@qvac/sdk, WDK, Hyperswarm) tracked by open integration issues — none of which are actually in anypackage.jsonyet. Meanwhile the build/UI tooling that is installed today (React, Vite, TypeScript, Vitest) wasn't disclosed at all. Per the hackathon rules, an omitted disclosed base disqualifies the entry.Changes
@vitejs/plugin-react, TypeScript, and Vitest under the latter, with a note that none of them run inference, call a remote API, or collect analytics.dependencies/devDependenciesentry across all workspacepackage.jsonfiles and cross-checking against the README.Closes
Closes #13
Notes
This issue is explicitly ongoing ("treat every PR that adds a dependency as needing a README update too") — this PR brings the list current as of today; future PRs adding a dependency still need to update it themselves.
🤖 Generated with Claude Code