Skip to content

UK study variant - #216

Open
lukaskollmer wants to merge 10 commits into
feature/track-grove-0.3.0-beta.8from
lukas/uk-study-variant-fixes
Open

lukaskollmer wants to merge 10 commits into
feature/track-grove-0.3.0-beta.8from
lukas/uk-study-variant-fixes

Conversation

@lukaskollmer

@lukaskollmer lukaskollmer commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

♻️ Current situation & Problem

Consent lookup needs the selected study variant's region embedded in the requested language locale. Supplying a separate locale region can leave Grove matching only the language or its original region.

This follows #215 and adds the consent lookup correction and diagnostics for internal UK testing. It uses the placeholder consent from SchmiedmayerLab/MyHeartCounts-StudyDefinitions#48.

⚙️ Release Notes

  • Build the consent locale from the preferred language code and the study variant's language region.
  • Add consent-resolution coverage for US English, US Spanish, and UK English locale constructions.
  • Show the active study variant and Firebase backend in account debug information.
  • Use the UK placeholder consent branch and temporarily default to the study bundle shipped with the app.

📚 Documentation

The consent loader documents why the study region must be passed as languageRegion. This PR does not change Grove's matching implementation.

The later FHIR PR #204 has a separate StudyDefinitions dependency containing questionnaire-contract changes. Reconciling that dependency with the UK placeholder consent is deferred to its merge-conflict review.

✅ Testing

ConsentLoadingTests.consentLoading() covers the supported consent locales and equivalent locale constructions. Tests were not rerun as part of inserting this existing branch into the stack.

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 2760a946-f2e6-4c92-a255-5da29a0cf75c


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lukaskollmer
lukaskollmer force-pushed the lukas/uk-study-variant-fixes branch from 749b060 to 7fcf19a Compare September 26, 2026 11:16
@lukaskollmer lukaskollmer changed the title Fix consent selection for UK study testing UK study variant Sep 26, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant