Repository navigation
UK study variant - #216
Open
lukaskollmer wants to merge 10 commits into
Open
UK study variant#216lukaskollmer wants to merge 10 commits into
lukaskollmer wants to merge 10 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 26, 2026
lukaskollmer
added this pull request to stack #217
September 26, 2026 07:30
lukaskollmer
force-pushed
the
lukas/uk-study-variant-fixes
branch
from
September 26, 2026 11:16
749b060 to
7fcf19a
Compare
…miedmayerLab/MyHeartCounts-iOS into lukas/uk-study-variant-fixes
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♻️ Current situation & Problem
Consent lookup needs the selected study variant's region embedded in the requested language locale. Supplying a separate locale region can leave Grove matching only the language or its original region.
This follows #215 and adds the consent lookup correction and diagnostics for internal UK testing. It uses the placeholder consent from SchmiedmayerLab/MyHeartCounts-StudyDefinitions#48.
⚙️ Release Notes
📚 Documentation
The consent loader documents why the study region must be passed as
languageRegion. This PR does not change Grove's matching implementation.The later FHIR PR #204 has a separate StudyDefinitions dependency containing questionnaire-contract changes. Reconciling that dependency with the UK placeholder consent is deferred to its merge-conflict review.
✅ Testing
ConsentLoadingTests.consentLoading()covers the supported consent locales and equivalent locale constructions. Tests were not rerun as part of inserting this existing branch into the stack.Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: