Repository navigation
Track Grove 0.3.0-beta.8 - #213
Open
PSchmiedmayer wants to merge 9 commits into
Open
PSchmiedmayer wants to merge 9 commits into
PSchmiedmayer wants to merge 9 commits into
Conversation
github-project-automation
Bot
moved this to In Progress
in MyHeart Counts Project Planning
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PSchmiedmayer
added this pull request to stack #214
September 24, 2026 03:17
PSchmiedmayer
force-pushed
the
feature/track-grove-0.3.0-beta.8
branch
from
September 24, 2026 03:45
e796e7b to
bdc28f3
Compare
1 task done
PSchmiedmayer
force-pushed
the
feature/track-grove-0.3.0-beta.8
branch
from
September 24, 2026 21:42
bdc28f3 to
99c847a
Compare
lukaskollmer
self-requested a review
September 25, 2026 06:59
…artCounts-iOS into feature/track-grove-0.3.0-beta.8 # Conflicts: # MyHeartCounts/MyHeartCountsStandard.swift # MyHeartCounts/Onboarding/AccountOnboarding.swift
lukaskollmer
marked this pull request as ready for review
September 25, 2026 17:26
lukaskollmer
removed this pull request from stack #214
September 26, 2026 07:30
lukaskollmer
added this pull request to stack #217
September 26, 2026 07:30
lukaskollmer
approved these changes
Sep 26, 2026
lukaskollmer
left a comment
lukaskollmer
left a comment
Collaborator
There was a problem hiding this comment.
added a couple of additional things, mainly around CI handling (UI job logs now show the xctest output, and we combine all UI testing xcresult files into a single one)
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♻️ Current situation & Problem
#202 migrates the app to Grove
0.3.0-beta.6.Grove
0.3.0-beta.8moves onboarding actions toPageActions, renames the account events, and floats the account and consent actions.#204 builds on those UI changes, so this PR takes them on their own and #204 keeps only the FHIR port.
⚙️ Release Notes
0.3.0-beta.8;MyHeartCountsSharedrequires0.3.0-beta.8up to the next minor.OnboardingActionsViewwithPageActions.handleAccountEvent(_:)with the renamed cases; log-out handling moves into.willLogOut.createAccountLinkandsignUpButtonand read the consent button's Ready/Incomplete value.📚 Documentation
No public interface changes.
StudyDefinitions stays on the revision #202 pins (SchmiedmayerLab/MyHeartCounts-StudyDefinitions#46), which accepts beta.8; StudyDefinitions
mainstill pins0.3.0-beta.2.✅ Testing
SwiftLint strict, the app build, app unit tests (18),
MyHeartCountsSharedon macOS and on Linux in Debug and Release, and the Onboarding, Consent, HealthDashboard and TaskHandling UI tests against the Firebase emulators (20 run, 2 existing skips).MyHeartCountsSharedon iOS 26.5 fails to load its test bundle when built with Xcode 27, because swift-collections 1.7.0 references a Swift 6.4 runtime symbol that iOS 26 lacks; it passes on iOS 27 and with swift-collections 1.6.0, and CI's Xcode 26.6 is not affected. Grove #67 caps swift-collections below 1.7.0, which #204 picks up.Code of Conduct & Contributing Guidelines