Skip to content

fix!: failure instead of neutral missing req approval #4816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eakmanrq merged 1 commit into from
Jun 26, 2025
Merged

fix!: failure instead of neutral missing req approval #4816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sqlmesh/integrations/github/cicd/command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def _check_required_approvers(controller: GithubController) -> bool:
)
return True
controller.update_required_approval_check(
status=GithubCheckStatus.COMPLETED, conclusion=GithubCheckConclusion.NEUTRAL
status=GithubCheckStatus.COMPLETED, conclusion=GithubCheckConclusion.FAILURE
)
return False

Expand Down
4 changes: 2 additions & 2 deletions tests/integrations/github/cicd/test_github_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ def test_run_all_missing_approval(
assert GithubCheckStatus(approval_checks_runs[0]["status"]).is_queued
assert GithubCheckStatus(approval_checks_runs[1]["status"]).is_in_progress
assert GithubCheckStatus(approval_checks_runs[2]["status"]).is_completed
assert GithubCheckConclusion(approval_checks_runs[2]["conclusion"]).is_neutral
assert GithubCheckConclusion(approval_checks_runs[2]["conclusion"]).is_failure

assert len(controller._context.apply.call_args_list) == 1
pr_plan = controller._context.apply.call_args_list[0][0]
Expand All @@ -402,7 +402,7 @@ def test_run_all_missing_approval(
output = f.read()
assert (
output
== "run_unit_tests=success\nhas_required_approval=neutral\ncreated_pr_environment=true\npr_environment_name=hello_world_2\npr_environment_synced=success\nprod_plan_preview=success\nprod_environment_synced=skipped\n"
== "run_unit_tests=success\nhas_required_approval=failure\ncreated_pr_environment=true\npr_environment_name=hello_world_2\npr_environment_synced=success\nprod_plan_preview=success\nprod_environment_synced=skipped\n"
)


Expand Down
4 changes: 2 additions & 2 deletions tests/integrations/github/cicd/test_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1040,7 +1040,7 @@ def test_no_merge_since_no_deploy_signal(
assert GithubCheckStatus(approval_checks_runs[0]["status"]).is_queued
assert GithubCheckStatus(approval_checks_runs[1]["status"]).is_in_progress
assert GithubCheckStatus(approval_checks_runs[2]["status"]).is_completed
assert GithubCheckConclusion(approval_checks_runs[2]["conclusion"]).is_neutral
assert GithubCheckConclusion(approval_checks_runs[2]["conclusion"]).is_failure
assert approval_checks_runs[2]["output"]["title"] == "Need a Required Approval"
assert (
approval_checks_runs[2]["output"]["summary"]
Expand Down Expand Up @@ -1068,7 +1068,7 @@ def test_no_merge_since_no_deploy_signal(
output = f.read()
assert (
output
== "run_unit_tests=success\nhas_required_approval=neutral\ncreated_pr_environment=true\npr_environment_name=hello_world_2\npr_environment_synced=success\nprod_plan_preview=success\nprod_environment_synced=skipped\n"
== "run_unit_tests=success\nhas_required_approval=failure\ncreated_pr_environment=true\npr_environment_name=hello_world_2\npr_environment_synced=success\nprod_plan_preview=success\nprod_environment_synced=skipped\n"
)


Expand Down