fix!: failure instead of neutral missing req approval#4816
Merged
Conversation
eakmanrq
force-pushed
the
eakmanrq/have_required_checks_return_falure_if_missing
branch
from
2b0fbad to
64ffa9c
Compare
eakmanrq
force-pushed
the
eakmanrq/have_required_checks_return_falure_if_missing
branch
from
64ffa9c to
023331b
Compare
erindru
approved these changes
Jun 26, 2025
eakmanrq
deleted the
eakmanrq/have_required_checks_return_falure_if_missing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking since this is a behavior change of the bot. This would impact Github CI/CD bot users if they had logic in their workflows that relied on the neutral output.
Prior to this change, if a user had branch protection rules in-place the neutral status would allow merging. This would not be expected by users since they want to see this check pass before merging. Therefore this PR changes the status to failure instead of neutral to better support this pattern.