-
Notifications
You must be signed in to change notification settings - Fork 165
Testing Pose bindings/numeric unit tests with standard PyRosetta builds #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
klimaj
wants to merge
14
commits into
RosettaCommons:main
Choose a base branch
from
klimaj:test_builds
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+149
−64
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
610320a
Initial commit
klimaj 7fce8d3
Remove duplicate tests; exit if numpy is not installed
klimaj 90135a7
Also install numpy in non-serialization builds
klimaj 242a3b0
Remove exit on missing numpy requirement
klimaj 0dc2dbb
Install numpy in non-serialization builds in get_required_pyrosetta_p…
klimaj a4e8faf
Merge branch 'RosettaCommons:main' into test_builds
klimaj 3a88b90
Merge branch 'test_builds' of github.com:klimaj/rosetta into test_builds
klimaj aa32819
git diff main...fix_diagnostics_port | git apply
klimaj c8e5d90
Skipping Pose object serialization for non-serialization builds
klimaj bc91b52
Remove scipy dependency via a numpy-only equivalent implementation
klimaj 4c1f2e4
Skipping Pose object serialization for non-serialization builds
klimaj a2e7def
Skipping Pose object serialization for non-serialization builds
klimaj f91b16d
Setting default pickle protocol for Python 3.7
klimaj 04669b4
Setting default pickle protocol for Python 3.7
klimaj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # :noTabs=true: | ||
| # (c) Copyright Rosetta Commons Member Institutions. | ||
| # (c) This file is part of the Rosetta software suite and is made available under license. | ||
| # (c) The Rosetta software is developed by the contributing members of the Rosetta Commons. | ||
| # (c) For more information, see http://www.rosettacommons.org. | ||
| # (c) Questions about this can be addressed to University of Washington CoMotion, email: license@uw.edu. | ||
|
|
||
| __author__ = "Jason C. Klima" | ||
|
|
||
| from utils.distributed import run_unittest | ||
|
|
||
| if __name__ == "__main__": | ||
| run_unittest("pyrosetta.tests.bindings.core.test_pose", timeout=60) | ||
13 changes: 13 additions & 0 deletions
13
source/src/python/PyRosetta/src/test/T022_Pose_Alignment.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # :noTabs=true: | ||
| # (c) Copyright Rosetta Commons Member Institutions. | ||
| # (c) This file is part of the Rosetta software suite and is made available under license. | ||
| # (c) The Rosetta software is developed by the contributing members of the Rosetta Commons. | ||
| # (c) For more information, see http://www.rosettacommons.org. | ||
| # (c) Questions about this can be addressed to University of Washington CoMotion, email: license@uw.edu. | ||
|
|
||
| __author__ = "Jason C. Klima" | ||
|
|
||
| from utils.distributed import run_unittest | ||
|
|
||
| if __name__ == "__main__": | ||
| run_unittest("pyrosetta.tests.numeric.test_alignment", timeout=30) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-- i guess this is one way to take care of this issue but the issue is that test will get silently "green" if no numpy was installed. Have you considered updating
get_required_pyrosetta_python_packages_for_release_packageso it returns at leastnumpyfor non-distributed platform? That way we should always be able to run this test. Thoughts?https://github.com/RosettaCommons/rosetta/blob/main/tests/benchmark/tests/__init__.py#L520
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lyskov Thanks for reviewing, and good point - I have now updated both
get_required_pyrosetta_python_packages_for_release_packageandget_required_pyrosetta_python_packages_for_testingto directly installnumpyand removed the silent green mechanism (for reference, this is the same mechanism we currently use to skip T900-T921 tests on non-serialization builds, which are not fully silent since they print warnings when skipping due to missing packages). I agree, let's not exacerbate the issue by adding more skipping behavior. The T021 and T022 tests now pass without being skipped and will error out ifnumpyis missing.