Testing Pose bindings/numeric unit tests with standard PyRosetta builds#708
Testing Pose bindings/numeric unit tests with standard PyRosetta builds#708klimaj wants to merge 14 commits into
Conversation
|
|
||
| if __name__ == "__main__": | ||
| exit_if_missing_numpy_requirement() | ||
| run_unittest("pyrosetta.tests.bindings.core.test_pose", timeout=60) |
There was a problem hiding this comment.
-- i guess this is one way to take care of this issue but the issue is that test will get silently "green" if no numpy was installed. Have you considered updating get_required_pyrosetta_python_packages_for_release_package so it returns at least numpy for non-distributed platform? That way we should always be able to run this test. Thoughts?
https://github.com/RosettaCommons/rosetta/blob/main/tests/benchmark/tests/__init__.py#L520
There was a problem hiding this comment.
@lyskov Thanks for reviewing, and good point - I have now updated both get_required_pyrosetta_python_packages_for_release_package and get_required_pyrosetta_python_packages_for_testing to directly install numpy and removed the silent green mechanism (for reference, this is the same mechanism we currently use to skip T900-T921 tests on non-serialization builds, which are not fully silent since they print warnings when skipping due to missing packages). I agree, let's not exacerbate the issue by adding more skipping behavior. The T021 and T022 tests now pass without being skipped and will error out if numpy is missing.
2 participants
This PR splits out two tests from
T900_distributed.pythat don't require thepyrosetta.distributedframework, but instead only rely onnumpyand ought to be tested by the standard PyRosetta builds.