Repository navigation
Conversation
npm ci has been failing on main since #24 (Install dependencies step, run 32722050710) and still fails after #25. The lockfile was left missing several entries that the tree requires: the istanbul chain used by coverage (make-dir, html-escaper, nested semver), the vitest coverage stack (@vitest/coverage-v8, @bcoe/v8-coverage, ast-v8-to-istanbul, magicast), and a few nested helpers. This adds back exactly those entries with registry metadata. No dependency version changes - every existing pin is untouched, so resolved behavior is identical to before #24.
… render a85edcb wired <Leaderboard> to a view prop but never declared leaderboardView, throwing ReferenceError during render (Dashboard.tsx:164) — caught by the Dashboard tests once CI could run them again. Call the existing useLeaderboard() hook like LeaderboardPage does, and drop the mockLeaderboardPlayers import left unused by the same rework (TS6133).
The success cases persist a real token; the later fail-closed case then read that stale entry instead of null. Clear storage in beforeEach so the cases stay order-independent.
Contributor
Author
|
Same story as #30: the Dashboard/test-isolation fixes here reached main via other merges, and the lockfile has since shifted under multiple PRs — a rebased version would be a third competing repair. Standing down; the two gameplay PRs this was unblocking are already merged and credited. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #30. With
npm ciworking again, CI's test step finally ran on main and surfaced 3 real failures (48/51 passing, run 32965733805):1.
ReferenceError: leaderboardView is not defined— Dashboard.tsx:164 (both Dashboard tests)a85edcb (leaderboard backend rework) wired
<Leaderboard view={...} />but never declared the variable — the Dashboard page throws during render for every visitor. This wires up the existinguseLeaderboard()hook exactly likeLeaderboardPage.tsx:61does, and dropsmockLeaderboardPlayerswhich that rework left unused (tscflags it with TS6133 under noUnusedLocals).2. AuthService "fails closed when the response is missing token/user"
The success cases earlier in the file persist a real token; this case then read that stale entry instead of null.
signInitself validates before persisting — the gap was test isolation. AddedlocalStorage.clear()inbeforeEach.Verification
tsc -p tsconfig.app.json --noEmit→ cleanMerging this plus #30 gets main back to fully green, which also unblocks the pending checks on #26/#27.