Repository navigation
Conversation
npm ci has been failing on main since #24 (Install dependencies step, run 32722050710) and still fails after #25. The lockfile was left missing several entries that the tree requires: the istanbul chain used by coverage (make-dir, html-escaper, nested semver), the vitest coverage stack (@vitest/coverage-v8, @bcoe/v8-coverage, ast-v8-to-istanbul, magicast), and a few nested helpers. This adds back exactly those entries with registry metadata. No dependency version changes - every existing pin is untouched, so resolved behavior is identical to before #24.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
Contributor
Author
|
Closing this — its purpose got served by side doors: #28/#32's chains landed their own lockfile repairs and test fixes on main (absorbing most of what this PR carried), and the gameplay PRs merged through regardless of CI state. With several people now touching the lockfile in parallel I don't want to add a competing repair on top — main's remaining npm ci gaps are better sorted by whoever's actively in that file. Thanks for merging #26/#27! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
npm cifails on main since #24 was merged (CI run 32722050710, "Install dependencies" step) and still fails after #25 (run 32725539180). Every open PR inherits the failure because CI merges main in first — that's why the test checks on #26/#27 are red even though their code is fine.The lockfile is missing several entries that the dependency tree requires:
make-dir,html-escaper, nestedsemver@vitest/coverage-v8,@bcoe/v8-coverage,ast-v8-to-istanbul(+ nestedjs-tokens),magicast@humanfs/types,@napi-rs/lzma-linux-x64-gnu,eslint-visitor-keysunder visitor-keys)Reproduced locally:
npm cion main exits with EUSAGE listing exactly those missing packages.Fix
Adds back those 12 entries with registry metadata (version, resolved URL, integrity, engines, bin). No existing pin is touched — 0 deletions in the diff, every resolved version stays identical to pre-#24, so installed behavior doesn't change.
I deliberately avoided regenerating the whole file: a full
npm installre-resolve drifts ~168 packages to newer versions within their ranges, which is churn this fix doesn't need.Verification
npm ci→ exit 0 on this branchOnce this lands, the Install step goes green again and the pending test runs on #26/#27 reflect their actual code.