Repository navigation
Conversation
aharlap
force-pushed
the
feat/composer-pattern-staleness
branch
2 times, most recently
from
October 20, 2026 01:37
e27891d to
587bc32
Compare
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
aharlap
force-pushed
the
feat/composer-pattern-staleness
branch
from
October 20, 2026 02:44
587bc32 to
37cebd8
Compare
Contributor
Author
|
Closing for now (controller decision, 2026-10-20). The Opus review showed that generating the composer's pattern table from the current README sections makes the composer's guidance worse: six READMEs are thin (several avoid cells are only 'It gives no grade', course-lookup has none), and the copied-README-plus-hashes check catches only hand edits, not upstream changes. Revisit after the READMEs carry real use/avoid guidance, with a simpler design: learning-patterns publishes the extracted sections at a pinned revision and Rubato reads that one artifact. The hand-written patterns.md on main stays the composer's source until then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #31, targeting
feat/composer-skill.Generate the composer's library use/avoid table from pinned READMEs and fail CI when the table differs. Remove the old hand-copied guidance while retaining Studio support, barriers, fallbacks and composition guidance.
Following Rubato's source-revision and SHA-256 convention, keep an MIT-licensed README snapshot and per-file hashes under
docs/provenance/. The snapshot comes fromPraxity/learning-patterns@e9d4fb6989135a44d75f0765c61d3a596a5d4428, the merged headings change from Praxity/learning-patterns#51. The check runs offline, requires no dependencies, and rejects hash mismatches before regenerating. No live clone or moving branch is used in CI.Validation: 34 affected tests pass, covering stale composer/source text, deliberate pin updates, malformed sections, missing files and source tampering; composer check, manifest/release validation, syntax checks and whitespace check pass. Verified all 15 copied files against the source commit. Regenerated adapter golden hashes. Full suites left to CI; CI pending at submission.
Depends on #31 and Praxity/learning-patterns#51. The final library review moved setup notes out of the selection headings. The checker excludes those notes and preserves course-lookup's empty avoid cell without inventing guidance. No merge requested.