Repository navigation
Give every pattern use-when and avoid-when sections - #51
Merged
Merged
Conversation
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split all 14 pattern READMEs into
Use it whenandAvoid it when, preserving every original word and adding no guidance.Final review fixes move the journal distress-check paragraph, test-out host-course note, course-lookup implementation/scaling notes and dont-know scoring setup into an optional
Setting it upsection after the selection headings. The structure guard covers its allowed position and rejects duplicates. Course-lookup's avoid heading remains empty for the owner to supply a condition; all other selection sections remain required and nonempty.Sol's stale site-comment reference is fixed in Praxity/praxity-site#77. Rubato's offline staleness checker and pinned README copy are in Praxity/rubato#32, stacked on Praxity/rubato#31 and updated to this PR's final revision.
Checks: README tests 7/7, typecheck and whitespace check pass. Added guard cases failed before the guard change. Verified all 14 READMEs retain every original word. Full and browser suites left to CI; CI pending after the final push.
Owner follow-ups only: thin use/avoid guidance in conversation, explain-back, course-lookup, live-feedback, misconception and journal; a home in those READMEs for the AI server requirement. No new guidance added here.
Review: 0/1/4; fixes 1.
Round 1: Sol 0/0/1, Opus 0/1/3. Final fix applied. There will be no further review round.