Skip to content

test: an event JSON cannot serialize is dropped alone #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eli-r-ph wants to merge 1 commit into
base: v1
Choose a base branch
from
+6 −0
Draft

test: an event JSON cannot serialize is dropped alone #1138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions posthog/test/test_before_send.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@
)


_CIRCULAR: dict = {}
_CIRCULAR["self"] = _CIRCULAR


class TestClient(unittest.TestCase):
@classmethod
def setUpClass(cls):
Expand Down Expand Up @@ -259,6 +263,8 @@ def test_before_send_callback_non_dict_output_drops_event(self):
"private-value",
["malformed", "valid"],
),
# A value json cannot write costs only that event.
("circular_reference", "private-key", _CIRCULAR, ["valid"]),
]
)
def test_malformed_before_send_event_does_not_stop_consumer_or_shutdown(
Expand Down
Loading