Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The 8.0 migration guide says an event that can't be serialized to JSON, such as one with a circular reference, is dropped and logged. Since #1120 removed the non-finite case, no test checks that such an event costs only itself and not its batch.
test_malformed_before_send_event_does_not_stop_consumer_or_shutdown: the bad event is dropped, the valid event in the same batch is sent, and the consumer and shutdown still finish.💚 How did you test it?
pytest posthog/test/test_before_send.py -k malformed: 2 passed. Without the per-event serialization guard, the whole batch fails to serialize and the valid event is never sent, so the case fails.📝 Checklist
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Claude Code (Claude Opus 5.5) added this test in response to a review comment on #1120.
🤖 Generated with Claude Code