Repository navigation
chore!: remove SessionRecordingConfig.screenshot - #109
Open
turnipdabeets wants to merge 1 commit into
Open
turnipdabeets wants to merge 1 commit into
turnipdabeets wants to merge 1 commit into
Conversation
posthog-android 4.0 and posthog-ios 4.0 always record masked screenshots, so the flag no longer selects anything. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This was referenced Oct 29, 2026
turnipdabeets
marked this pull request as ready for review
October 29, 2026 14:50
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Stacked on #108 and depends on PostHog/posthog-android#908. posthog-android 4.0 removes wireframe replay and
PostHogSessionReplayConfig.screenshot, so #108 no longer compiles for Android without this. If PostHog/posthog-android#908 is dropped from 4.0, close this PR.💡 Motivation and Context
posthog-ios 4.0 (PostHog/posthog-ios#907, PostHog/posthog-ios#973) and posthog-android 4.0 (PostHog/posthog-android#908) both drop wireframe session replay. Replay always records masked screenshots. #108 already stopped forwarding
screenshotto iOS. Android's flag is now gone as well, soSessionRecordingConfig.screenshotdoesn't do anything on any platform.Changes:
SessionRecordingConfig.screenshotand stop passing it toPostHogSessionReplayConfigon Android.copyoverloads kept for the pre-verifyScreenshotMaskAlignmentsignature, along with their Java test (SessionRecordingConfigJavaTest). That signature includedscreenshot, so it can't be kept. Leaving a 7-argument overload next to the primary constructor would also makeSessionRecordingConfig()ambiguous.verifyScreenshotMaskAlignmentKDoc.minorwith a Breaking: entry, the same as chore!: adopt posthog-android 4.0, core 7.0 and posthog-ios 4.0 #108.This removes the option rather than deprecating it, matching the native SDKs. An app that set
screenshot = falseto keep pixels out of recordings gets a compile error instead of silently uploading masked screenshots.💚 How did you test it?
Built against posthog-android 4.0.0 / core 7.0.0 published from PostHog/posthog-android#908 to a local Maven repo, using an init script so the build files stay unchanged:
PostHogAndroidConfigTest(4),PostHogConfigTeston Android host and JVM (16 each),PostHogConfigJavaTest(2): pass.:sample:androidApp:compileDebugKotlin: pass.testCaptureRoutesCorrectly,testAliasRoutesCorrectly, …) fail withexpected [new_alias, null] but was [new_alias]. chore!: adopt posthog-android 4.0, core 7.0 and posthog-ios 4.0 #108 alone fails the same 12 JVM tests against these artifacts: they expect the trailingoptionsargument from the capture-v1 PRs (feat!: send events through capture v1 and add captureAi posthog-android#881/#882), which aren't in this Android base. chore!: adopt posthog-android 4.0, core 7.0 and posthog-ios 4.0 #108 alone can't compile Android against these artifacts, so there's no Android-host baseline. Its 10 failures are the same routing tests with the same message.iosMain/appleMain, andcommonMainonly loses a constructor parameter.📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
@Deprecatedno-op is a small change.🤖 Generated with Claude Code