Repository navigation
fix(react-native-plugin): require posthog-android 3.73.2 - #5483
turnipdabeets wants to merge 1 commit into
Conversation
![posthog[bot]](https://avatars.githubusercontent.com/in/1203049?s=60&v=4){kind=small}
There was a problem hiding this comment.
PostHog Review · Standard · reviewed e440e6d: 1 Must fix.
This is the only automatic review while this pull request is a draft. Comment @posthog review to review new changes sooner. Otherwise, a review of the new changes runs when you mark it ready for review.
See this review and its findings in PostHog Review. Comment @posthog review --deep for a Deep review. A Deep review takes longer and looks deeper than a Standard review.
| implementation "com.facebook.react:react-native:+" | ||
| implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" | ||
| implementation "com.posthog:posthog-android:3.72.9" | ||
| implementation "com.posthog:posthog-android:3.73.2" |
There was a problem hiding this comment.
P1 · Wait for the Android artifact to be published before requiring it
Android builds resolving this plugin fail because Maven Central returns HTTP 404 for com.posthog:posthog-android:3.73.2. This unconditional implementation dependency blocks compilation even when session replay is disabled. Keep the PR blocked until the artifact is published, then verify the released version contains the fixes and passes Android CI.
Coherence0 spec problems · 0 failing chokepoints · 2 spec gaps · 0 guard failures 44 components, 7 bullets (5 invariants, 2 requirements), 0 problems Chokepoints: none declared. Spec gaps: 2 entrances with outside or unknown trust and no traced control, and 10 more held by the adoption baseline
Close one with |
Note
Draft until posthog-android 3.73.2 is released. It doesn't exist yet, so Android CI can't resolve it. Waits on the posthog-android fix in PostHog/posthog-android#910.
Problem
On Android, the plugin always runs session replay in screenshot mode (
sessionReplayConfig.screenshot = true), so every RN app with replay on Android has two privacy gaps from posthog-android 3.x:FLAG_SECURE(banking, password screens) are recorded like any other screen.The upcoming posthog-android patch fixes both:
FLAG_SECUREwindows are recorded fully masked, and those frames are dropped. The plugin pins posthog-android to exactly3.72.9, so RN apps won't pick it up without this bump.Changes
com.posthog:posthog-androidfrom3.72.9to3.73.2inpackages/react-native-plugin/android/build.gradle.@posthog/react-native-plugin.No plugin code changes: the capture runs inside posthog-android. The 3.72.9 → 3.73.1 public API diff only touches
posthog-server, so the plugin's use ofPostHogSessionReplayConfigand the screenshot options is unaffected. RN also picks up 3.72.10's fix forbeforeSendrunning twice and 3.73.0's$is_sideloadedproperty on native events.3.73.2assumes the fix ships as the next posthog-android patch. I'll re-check the version and the changeset wording before marking this ready.Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
🤖 Generated with Claude Code