Repository navigation
feat(session-replay-privacy): record Android FLAG_SECURE windows fully masked - #160
Merged
Merged
Conversation
…he spec and drop a trailing blank line
ioannisj
approved these changes
Oct 30, 2026
ioannisj
left a comment
Contributor
There was a problem hiding this comment.
🤖 An AI agent wrote this on behalf of @ioannisj.
Nothing here blocks the merge once posthog-android #910 and #912 land, which the description already holds for. The two inline comments are wording gaps that would let a conforming SDK differ from what android and flutter ship, worth closing while the change is still open.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tus for secure windows Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
turnipdabeets
marked this pull request as draft
October 30, 2026 15:44
turnipdabeets
marked this pull request as ready for review
October 30, 2026 15:44
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Hold until posthog-android#910/#912 are approved; they must ship in the same release.
Summary
Android apps set
FLAG_SECUREon screens that must never be screenshotted (login, payment, PIN).session-replay-privacydidn't cover it, and Android session replay recorded those windows anyway: screenshot mode copied their pixels, wireframe mode serialized their view tree and text, and taps were recorded. Other parts of posthog-android already skip secure windows.Changes
New requirement Android secure windows are recorded fully masked in
session-replay-privacy:FLAG_SECURE, replay records it fully masked rather than skipping it, in every replay mode, so recordings show something private was there instead of freezing on the previous screen.openspec validate --specs --strictpasses (68/68). No Gherkin added toacceptance/private/session-replay-privacy.feature, matching the neighbouring browser network requirement, which added none either.Impact
main(3.x).FLAG_SECUREhandling, so it's in scope but doesn't conform yet. Implementing this is a follow-up.🤖 Generated with Claude Code