Repository navigation
chore(react-native-plugin)!: require posthog-ios 4.0 - #5237
turnipdabeets wants to merge 6 commits into
Conversation
posthog-ios 4.0 isn't released yet; this PR keeps only the Xcode 26 CI lanes.
1e813ac to
0422ed4
Compare
* chore(react-native-plugin)!: require posthog-ios 4.0 and leave out its Surveys trait The plugin disables native surveys (React Native surveys are rendered in JS), so its Swift package depends on posthog-ios with only the SessionReplay and CrashReporting traits. The manifest moves to tools 6.2, which posthog-ios 4.0 requires anyway and which package traits need. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * ci(react-native-plugin): build CocoaPods lanes on Xcode 26 * chore(react-native-plugin): move the posthog-ios 4.0 pin to #5237 posthog-ios 4.0 isn't released yet; this PR keeps only the Xcode 26 CI lanes. --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
93428a3 to
6fed091
Compare
* chore(react-native-plugin)!: require posthog-ios 4.0 and leave out its Surveys trait The plugin disables native surveys (React Native surveys are rendered in JS), so its Swift package depends on posthog-ios with only the SessionReplay and CrashReporting traits. The manifest moves to tools 6.2, which posthog-ios 4.0 requires anyway and which package traits need. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * ci(react-native-plugin): build CocoaPods lanes on Xcode 26 * chore(react-native-plugin): move the posthog-ios 4.0 pin to #5237 posthog-ios 4.0 isn't released yet; this PR keeps only the Xcode 26 CI lanes. --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
690bd16 to
ebbddb7
Compare
Coherence📄 0 spec file errors · ⛔ 0 broken rules · 🚪 2 unchecked inputs · 🐛 0 bugs that came back What is Coherence?Coherence compares the code with its spec files ( This check read 44 parts of the code and 7 rules. Note These findings do not make this check fail. None of these findings are in files that this pull request changes. You do not need to fix them in this pull request. 🚪 Unchecked inputs (2)
What this means and how to fix itInput from outside this code comes in at these places. The spec does not say what checks that input. 10 more places were already like this when Coherence was added. This list does not show them. To close one of these, find the place by its name in the
To get the line to add, run |
6fed091 to
50eb417
Compare
* chore(react-native-plugin)!: require posthog-ios 4.0 and leave out its Surveys trait The plugin disables native surveys (React Native surveys are rendered in JS), so its Swift package depends on posthog-ios with only the SessionReplay and CrashReporting traits. The manifest moves to tools 6.2, which posthog-ios 4.0 requires anyway and which package traits need. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * ci(react-native-plugin): build CocoaPods lanes on Xcode 26 * chore(react-native-plugin): move the posthog-ios 4.0 pin to #5237 posthog-ios 4.0 isn't released yet; this PR keeps only the Xcode 26 CI lanes. --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ebbddb7 to
45488c4
Compare
|
keep PRs like this in draft until its ready to go so its out of our review list |
c15386c to
c81d985
Compare
* chore(react-native-plugin)!: require posthog-ios 4.0 and leave out its Surveys trait The plugin disables native surveys (React Native surveys are rendered in JS), so its Swift package depends on posthog-ios with only the SessionReplay and CrashReporting traits. The manifest moves to tools 6.2, which posthog-ios 4.0 requires anyway and which package traits need. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * ci(react-native-plugin): build CocoaPods lanes on Xcode 26 * chore(react-native-plugin): move the posthog-ios 4.0 pin to #5237 posthog-ios 4.0 isn't released yet; this PR keeps only the Xcode 26 CI lanes. --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
posthog-ios 4.0 needs Xcode 26; package traits are left at their defaults.
… in the changelog
Surveys are rendered in JS; traits need swift-tools 6.1+, and posthog-ios 4.0 already requires Xcode 26.
…angeset and guide
45488c4 to
c3397e8
Compare
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
Warning
Prep PR: CI is expected to fail until posthog-ios 4.0 is released. The iOS and macOS example builds can't resolve
4.0.0from CocoaPods or SwiftPM yet. Merge into #5194 last, once 4.0 is published and CI is green. Plugin 3.0 is released only after this PR.Problem
#5194 (plugin 3.0) keeps posthog-ios at 3.88.2. This is the follow-up that moves to posthog-ios 4.0, which needs Xcode 26 and raises the floors to iOS 15 and macOS 11 (the plugin already matches those in #5194).
Changes
posthog_ios_versionin the podspec and the floor inios/Package.swiftmove to4.0.0.check-spm-manifest.mjskeeps checking that they match..changeset/rn-plugin-v3.md: Breaking posthog-ios 4.0 / Xcode 26, plus an entry for 4.0's behavior change: native uploads (replay, crash reports) pause while cellular data is turned off for the app, instead of sending requests that fail (PostHog/posthog-ios#909).ios/Package.swiftdepends on posthog-ios withtraits: ["SessionReplay", "CrashReporting"], leaving outSurveys(PostHog/posthog-ios#916, #918). The plugin setsconfig.surveys = falseand renders surveys in JS, so native surveys were dead weight. Replay and crash autocapture need the other two traits. Folded in from chore(react-native-plugin): leave out posthog-ios's Surveys trait #5238.ios/Package.swiftmoves from tools 6.0 to 6.2. Traits need 6.1+, and posthog-ios 4.0 already requires Xcode 26 (Swift 6.2).Surveys. CocoaPods has no traits andposthog.useSpmpasses none, so both still get the full SDK. SwiftPM turns a trait back on if any other package depends on posthog-ios with the defaults; nothing breaks, the code just isn't dropped.examples/example-rn-native-pluginsimulator Debug build succeeded with no plugin warnings once chore(react-native-plugin): drop screenshotMode for posthog-ios 4.0 #5236 is applied.Before merging
screenshotMode) can merge into chore(react-native-plugin)!: Major Release v3 #5194 before this PR. It's only correct with posthog-ios 4.0, so 3.0 can't release without this PR.SessionReplay,CrashReportingandSurveystraits (feat(web-analytics): Add site_name in config and $site_name property #916/feat: Show warning if identifying with "distinct_id" #918 are merged into the 4.0 stack). Naming a trait that doesn't exist fails package resolution..changeset/rn-plugin-v3.md.Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Made with Claude Code. Split out of #5226 so that PR (Xcode 26 CI lanes) can merge now, then split again for the traits change (#5238), which is now folded back in. The 4.0 build check merged #873 with the open 4.0 PRs locally, since 4.0 isn't tagged; #907 and #916 conflict on two color-util files there, so the iOS stack needs a rebase. Not tested: the
posthog.useSpmpath against 4.0, Release builds, running the app.🤖 Generated with Claude Code