Repository navigation
chore(react-native-plugin): drop screenshotMode for posthog-ios 4.0 - #5236
Merged
turnipdabeets merged 3 commits intoOct 28, 2026
Merged
Conversation
![veria-ai[bot]](https://avatars.githubusercontent.com/in/1723776?s=60&v=4){kind=small}
PR overviewAll previously flagged issues have been addressed. No open security concerns remain on this pull request. Security reviewNo open security issues remain on this pull request. Fixed/addressed: 1 · PR risk: 0/10 |
4 of 23 tasks
turnipdabeets
force-pushed
the
chore/rn-plugin-drop-screenshot-mode
branch
from
October 7, 2026 19:31
0afd890 to
369cace
Compare
turnipdabeets
changed the base branch from
chore/rn-plugin-v3
to
chore/rn-plugin-posthog-ios-4-pin
October 7, 2026 19:31
turnipdabeets
force-pushed
the
chore/rn-plugin-posthog-ios-4-pin
branch
from
October 7, 2026 19:35
1e813ac to
0422ed4
Compare
turnipdabeets
force-pushed
the
chore/rn-plugin-drop-screenshot-mode
branch
from
October 7, 2026 19:35
369cace to
14d4f6a
Compare
4 of 23 tasks
turnipdabeets
force-pushed
the
chore/rn-plugin-drop-screenshot-mode
branch
from
October 7, 2026 19:38
14d4f6a to
b56f376
Compare
turnipdabeets
changed the base branch from
chore/rn-plugin-posthog-ios-4-pin
to
chore/rn-plugin-v3
October 7, 2026 19:38
This was referenced Oct 7, 2026
dustinbyrne
approved these changes
Oct 7, 2026
Contributor
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
turnipdabeets
force-pushed
the
chore/rn-plugin-v3
branch
from
October 20, 2026 15:08
93428a3 to
6fed091
Compare
turnipdabeets
force-pushed
the
chore/rn-plugin-drop-screenshot-mode
branch
from
October 20, 2026 15:10
06416a3 to
878d1b7
Compare
Contributor
Coherence0 spec problems · 0 failing chokepoints · 2 spec gaps · 0 guard failures 44 components, 7 bullets (5 invariants, 2 requirements), 0 problems Chokepoints: none declared. Spec gaps: 2 entrances with outside or unknown trust and no traced control, and 10 more held by the adoption baseline
Close one with |
posthog-ios 4.0 always records screenshots, so the setting is a deprecated no-op.
turnipdabeets
force-pushed
the
chore/rn-plugin-v3
branch
from
October 26, 2026 16:28
6fed091 to
50eb417
Compare
turnipdabeets
force-pushed
the
chore/rn-plugin-drop-screenshot-mode
branch
from
October 26, 2026 16:28
878d1b7 to
445e574
Compare
This was referenced Oct 27, 2026
Member
|
@turnipdabeets should we merge this? its stale, approved etc |
4 of 24 tasks
turnipdabeets
added a commit
that referenced
this pull request
Oct 31, 2026
…5236) * chore(react-native-plugin): drop screenshotMode for posthog-ios 4.0 posthog-ios 4.0 always records screenshots, so the setting is a deprecated no-op. * chore(react-native-plugin): add changeset for dropping screenshotMode * chore(react-native-plugin): shorten screenshotMode changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Depends on PostHog/posthog-ios#907 (remove wireframe replay) shipping in posthog-ios 4.0. If #907 merges, this goes in too. If PostHog/posthog-ios#907 is dropped from 4.0, close this PR (or revert it if already merged): without #907, removing this line makes iOS replay fall back to wireframe.
Problem
posthog-ios 4.0 removes wireframe session replay (PostHog/posthog-ios#907). Replay always records masked screenshots, and
sessionReplayConfig.screenshotModebecomes a deprecated no-op. The plugin still sets it totrue, which will only produce a deprecation warning once we're on 4.0.Changes
config.sessionReplayConfig.screenshotMode = truefrom the iOS plugin.Stacked on #5194, and can merge into it before #5237 (the posthog-ios 4.0 pin), which goes in last. Until #5237 lands, the unreleased #5194 branch runs posthog-ios 3.88.2 without this line, which falls back to wireframe replay. That's fine only because #5194 isn't released without #5237.
Release info Sub-libraries affected
Libraries affected
Checklist
sessionReplayConfig.screenshot = true, since posthog-android still has wireframe mode)If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Prepared with Claude Code. Checked #907's diff:
screenshotModebecomes a deprecated property with no effect, andscreenshotModeBackgroundCapture(which the plugin also sets) keeps working without it. Not built locally on its own: on the 3.88.2 pin the build is unchanged, but replay would switch to wireframe, which is why 3.0 doesn't release without #5237. The 4.0 build check with this change applied passed (see #5237).🤖 Generated with Claude Code