Skip to content

Sound Effects (pt 1 continueation) - #3626

Open
Crepestrom wants to merge 79 commits into
PixelGuys:masterfrom
Crepestrom:esefeks-sfx-crepestrom-additions
Open

Crepestrom wants to merge 79 commits into
PixelGuys:masterfrom
Crepestrom:esefeks-sfx-crepestrom-additions

Conversation

@Crepestrom

Copy link
Copy Markdown
Contributor

working from the pr by RanPix
Continueing from: #3281

@Crepestrom

Copy link
Copy Markdown
Contributor Author

i have fixed all the previous issues
exept converting into mono

@Crepestrom

Copy link
Copy Markdown
Contributor Author

if its fine can i seperate the pr for loading sound effects from assets into a different one?

@Crepestrom
Crepestrom marked this pull request as ready for review September 20, 2026 05:15
@Crepestrom

Copy link
Copy Markdown
Contributor Author

how can i convert stereo sound into mono?

@RanPix

RanPix commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

how can i convert stereo sound into mono?

you can either use ffmpeg to convetr the sound files themselves or in audio struct sound loading it has conversions from mono to stereo, i think you can find it somewhere iirc

@Crepestrom

Copy link
Copy Markdown
Contributor Author

i think it could be useful to have stereo sounds for horror mods
but its probably fine

@IntegratedQuantum IntegratedQuantum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review your code before I do it.
If I find 3 unused functions before even looking at the interesting file, then that's not a good sign.

Comment thread src/gui/windows/audio.zig Outdated
Comment thread src/utils/list.zig Outdated
Comment thread src/utils/list.zig Outdated
Comment thread src/assets.zig Outdated
@Crepestrom

Copy link
Copy Markdown
Contributor Author

oops i missed some functions when changing the thing over to a cache

@Crepestrom

Copy link
Copy Markdown
Contributor Author

i will also say that the sounds do play and are affected by the sounds slider in the settings

@IntegratedQuantum

Copy link
Copy Markdown
Member

Please address all change requests from #3281
Also needs a rebase

@Crepestrom

Copy link
Copy Markdown
Contributor Author

i wasnt sure if i should comment on the old pr
but i will now

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

4 participants