Repository navigation
Sound Effects (pt 1 continueation) - #3626
Crepestrom wants to merge 79 commits into
Conversation
|
i have fixed all the previous issues |
|
if its fine can i seperate the pr for loading sound effects from assets into a different one? |
|
how can i convert stereo sound into mono? |
you can either use ffmpeg to convetr the sound files themselves or in audio struct sound loading it has conversions from mono to stereo, i think you can find it somewhere iirc |
|
i think it could be useful to have stereo sounds for horror mods |
IntegratedQuantum
left a comment
There was a problem hiding this comment.
Please review your code before I do it.
If I find 3 unused functions before even looking at the interesting file, then that's not a good sign.
Co-authored-by: IntegratedQuantum <43880493+IntegratedQuantum@users.noreply.github.com>
|
oops i missed some functions when changing the thing over to a cache |
|
i will also say that the sounds do play and are affected by the sounds slider in the settings |
|
Please address all change requests from #3281 |
|
i wasnt sure if i should comment on the old pr |
working from the pr by RanPix
Continueing from: #3281