Repository navigation
Conversation
|
also for now you can tp to 0 0 0 to hear a testing sound thats constantly playing for stereo |
|
CI failed but I also don't understand if this is supposed to be reviewed? |
|
I bring you good news |
YEEEEEEESSSSSSSSSSS, thank god its just a file issue |
|
ready for review |
|
finally we can have sound effects |
preparation for #3281 to reduce line count
|
are music and sound effects seperated? |
yes, look at the settings for audio |
|
ah good |
|
can you add a field along with volume that slightly randomizes the pitch/playback speed of the sound effect |
i tried implementing this several times and all of them were horrible, this will be a separate pr |
|
refer to this on sound effect system features #3364 |
There was a problem hiding this comment.
Sound effects should be in https://github.com/PixelGuys/Cubyz-Assets/ together with the music
There was a problem hiding this comment.
PixelGuys/Cubyz-Assets#39
i have a pr for it im just waiting for it to get added before i can add that functionality
There was a problem hiding this comment.
Ah, it's waiting for artistic review
| const audioData = audios.items[sound.audioIndex]; | ||
| const soundBuffer = audioData.data; | ||
|
|
||
| const notMonoInt: u32 = @intFromBool(audioData.channelType != .mono); |
There was a problem hiding this comment.
Can we forbid stereo tracks entirely? Ideally enforced through the conversion script in Cubyz-Assets.
There was a problem hiding this comment.
@ikabod-kee do we want stereo sounds? (not the directional spatial stuff in the game but the audio itself being stereo), having no stereo sounds would make things simplier
There was a problem hiding this comment.
setro tracks are just interpereted as mono with the first channel only being read
There was a problem hiding this comment.
Don't just blindly reinterpret stuff, log an error instead and discard the track.
It's potentially losing data and wasting performance, so I think we shouldn't allow it in the first place.
It's easy to reformat tracks as mono with any audio editor.
There was a problem hiding this comment.
ok throws a error and returns a null now
|
is this still being worked on? |
at the moment no, but you can overtake this pr if you are willing to finish it |
|
I am bored and willing to contribute |
|
good job making this pr |
|
moved to #3626 |
5 participants
requires #3367
this is mostly intended to be a base for other people to maybe continue on this
has a bit of renaming and test code, i still have to figure out what we will need
the questions i have for now:
and i also would want to discuss how the ideal api for that would look like, and maybe what tools do we give to the artists
todo:
doppler effect- separate prsimd sound mixing?- separate pr probablyplaying sounds limit- separate prvolume control based on how many of the same sounds are playing at the same time?- separate pr