feat(hangar_sim): enable fuse velocity_decay to prevent drift after nav2 stops#674
Conversation
259fb3b to
cb84e1a
Compare
caeffa1 to
eade712
Compare
|
eade712 to
6c5ba26
Compare
|
6c5ba26 to
21a9024
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR introduces a new ChangesMotion Model Velocity Decay Configuration
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/hangar_sim/config/fuse/fuse.yaml`:
- Around line 22-26: The new velocity_decay parameter in fuse.yaml may not be
supported by the installed fuse library; verify that PickNikRobotics/fuse#34 has
been merged and released, then pin or bump the required fuse package version in
the Dockerfile and dependency manifests (package.xml / rosdep keys) so the
runtime installs the release that adds velocity_decay, and confirm the
fixed_lag_smoother_node actually reads/validates the velocity_decay parameter
(search for fixed_lag_smoother_node and velocity_decay in the codebase and
update the node or wrapper to handle the parameter if missing).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6858accb-009c-495f-a987-6c1239e76a56
📒 Files selected for processing (1)
src/hangar_sim/config/fuse/fuse.yaml
|
21a9024 to
dd22c53
Compare
|
|
PickNikRobotics/moveit_pro#19565 has merged — the new fuse binary with |
Summary
Enables `velocity_decay: 1.0` in `hangar_sim/config/fuse/fuse.yaml` to use the new parameter added in PickNikRobotics/fuse#34.
Fixes the fuse estimate drifting diagonally after a nav2 Objective completes and `platform_velocity_controller_nav2` deactivates. Tracked in PickNikRobotics/moveit_pro#18070.
Depends on PickNikRobotics/moveit_pro#19565 being merged first (Dockerfile bump that pulls in the new fuse binary with `velocity_decay` support).
Claude agent checks