Skip to content

fix(test): use relative editable path so test.sh runs on Windows #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Betterchildren wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(test): use relative editable path so test.sh runs on Windows #607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,15 @@ fi

echo "[2/5] Installing this checkout and test dependencies"
python -m pip install --quiet --upgrade pip
python -m pip install --quiet -c "$REPO_ROOT/constraints.txt" -e "$REPO_ROOT[dev]"
# Install the editable target from a subshell cd'd into the repo with a
# relative ".[dev]". On Windows (Git Bash + native Python), an absolute
# "$REPO_ROOT[dev]" defeats MSYS path conversion: the trailing [dev] makes
# the argument look like a non-existent path, so the "/d/..." form is
# passed through unchanged and native pip rejects it as "not a valid
# editable requirement". A relative path avoids the conversion. The
# constraints path is kept absolute on purpose: the file exists, so MSYS
# converts it cleanly, and test_integration_script pins that exact spelling.
( cd "$REPO_ROOT" && python -m pip install --quiet -c "$REPO_ROOT/constraints.txt" -e ".[dev]" )

echo "[3/5] Verifying the installed CLI"
agent-reach version
Expand Down