fix(test): use relative editable path so test.sh runs on Windows - #607
Open
Betterchildren wants to merge 1 commit into
Open
fix(test): use relative editable path so test.sh runs on Windows#607Betterchildren wants to merge 1 commit into
Betterchildren wants to merge 1 commit into
Conversation
`test.sh` built the editable install target as `-e "$REPO_ROOT[dev]"`. On Windows with Git Bash + native Python, the trailing `[dev]` defeats MSYS path conversion: the argument no longer looks like an existing path, so the `/d/...` form is passed through unchanged and native pip rejects it as "not a valid editable requirement". The install step therefore aborted at [2/5] before any test could run. Install from a subshell cd'd into the repo using a relative `.[dev]`, matching what CI already does on windows-latest. The constraints path stays absolute (`$REPO_ROOT/constraints.txt`): the file exists, so MSYS converts it cleanly, and `test_integration_script` pins that exact spelling. Co-Authored-By: Claude Opus 4.8 <noreply@owtffssent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test.shbuilt the editable install target as-e "$REPO_ROOT[dev]". On Windows with Git Bash + native Python, the trailing[dev]defeats MSYS path conversion: the argument no longer looks like an existing path, so the/d/...form is passed through unchanged and native pip rejects it as "not a valid editable requirement". The install step therefore aborted at [2/5] before any test could run.Install from a subshell cd'd into the repo using a relative
.[dev], matching what CI already does on windows-latest. The constraints path stays absolute ($REPO_ROOT/constraints.txt): the file exists, so MSYS converts it cleanly, andtest_integration_scriptpins that exact spelling.