Repository navigation
Unify accuracy-mode configuration and preserve explicit clipping - #12
Merged
Merged
Conversation
3 of 6 tasks
1 of 4 tasks
Signed-off-by: Zhan Rongrui <me@zrr.dev>
zrr1999
marked this pull request as ready for review
September 16, 2026 02:00
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Use the existing
use_accuracy_compatibleargument for model and optimizer numerics. Delete the SFT initialization override that silently setsclip_gradto zero, and remove the separate reproducible-norm and native-unfused-AdamW arguments. DSA padding and bridge behavior follow the model architecture and shared mode. An older Megatron optimizer configuration that cannot honor this mode fails explicitly.Requires Megatron #17; PaddleFleet #1961 removes the retired options from the GLM cases. Reference wheels must include both companion changes.
Experiment results
model_info.configis populated.formal-ci-followup-20260915-n100-r1: all 100 loss values are IEEE bit-identical, provenance passes, and both canonical safetensors checkpoints match. Each side also matches its prior accepted 100-step loss and checkpoint. GLM4.5 native EP2 10-step regression has 40/40 matching loss hashes and matches the previous baseline on both sides. Local receipts:experiments/ops/ci-followup-20260915/terminal.jsonandglm45-pair-r0/comparison.json. Frozen repository pins, existing completion-required items and the incomplete native-build snapshot remain unresolved; this is candidate acceptance, not complete + sealed or remote-CI acceptance.