Repository navigation
Conversation
Let run_alignment_test.sh own environment setup and propagate setup failures. Signed-off-by: Zhan Rongrui <me@zrr.dev>
Signed-off-by: Zhan Rongrui <me@zrr.dev>
Signed-off-by: Zhan Rongrui <me@zrr.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Repair CI setup failures that prevent alignment and unit tests from reaching model execution. Use the CUDA 12.9 image and matching PaddleFleet ops wheel, following PFCCLab/Megatron-LM#19. Keep
run_alignment_test.shas the single owner of dependency installation and propagate setup failures.GPU unit tests now check out into a directory unique to the workflow run and attempt. Docker mounts that checkout read-only and copies it into a private container directory before running the unchanged test command. Build products and Git writes therefore cannot leave root-owned files in the host checkout. Cleanup removes only this run's checkout; it does not require sudo or alter older workspaces. CI-script changes now trigger GPU tests.
The hosted lint workflow uses pinned Node 24 actions. The GPU runner has modern runner software but an older glibc, so its workflow checks out the exact GitHub event commit using native Git, retaining PR merge depth and LFS behavior. Full-repository formatting fixes retain the same Python ASTs.
Experiment results
4b473796passed GPU model-accuracy alignment. The current head9bc18303also passed GPU model-accuracy alignment (job111320507250); its GPU unit and NPU jobs still need to pass. Local wrapper tests do not establish native hardware acceptance.Git LFS is initialized only in the disposable checkout. If the binary is missing, the job verifies the official v3.8.0 archive SHA-256 before using a temporary binary, then fetches, materializes and checks the LFS objects. The current GPU unit job fails closed because the host has Git 1.8.3.1, while Git LFS requires Git >= 2.0. An earlier diagnostic run also established that the required
/mnt/modelscope/ci_env.shis absent. A compatible, correctly configured runner is required; these are infrastructure blockers, not passing unit tests. The NPU job remains required.