Repository navigation
ci(rust): seed debug caches from dev and stop PR runs saving them - #759
Merged
Merged
Conversation
…ip changelog] Co-Authored-By: Joshua Tubbs <orin8722@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
…w runners don't trip it [skip changelog] Co-Authored-By: Joshua Tubbs <orin8722@gmail.com>
…commit skip markers [skip changelog] Co-Authored-By: Joshua Tubbs <orin8722@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust.ymlwas the only workflow that writes the Swatinemdebug-<OS>cache, but it never ran ondev. A PR can only restore caches from its own ref, its base branch, or the default branch, so every new PR built wxWidgets and the whole workspace from scratch on Linux, Windows and macOS. Every PR run also saved its own multi-GB cache that no other PR could use. Those caches count against the repo's 10 GB limit and can push out therelease-*/xtask-*caches fromrust-build.yml.devthat touchrust/**now run the same checks and save thedebug-<OS>caches. PRs intodevrestore those caches and no longer upload their own. Tag andworkflow_dispatchruns on other refs now only restore too.v*tag runs still happen as before. The CHANGELOG step still runs only onpull_request.Two fixes needed to get this PR green
aw-aitransport::tests::keeps_a_model_that_writes_longer_than_the_stall_limitfailed on macOS withDeadline("The AI model stopped answering for 0 seconds."). It sleeps 400 ms between chunks against a 0.5 s stall limit, which leaves only 100 ms of slack. The stall limit is now 1.0 s. Each gap is still under the limit, and the full write (about 1.2 s) still runs longer than it, so the test checks the same thing.[skip changelog]in CI.fetch-depth: ${{ matrix.os == 'ubuntu-latest' && 0 || 1 }}always evaluated to1: the bare0is falsy, so the expression falls through to|| 1(the log showsfetch-depth: 1on Linux). With a depth-1 checkout, the PR merge commit has no parents in the clone.git log --no-mergestherefore counts it as a normal commit, and because it has no skip marker the gate fails. Quoting the values as'0' || '1'gives Linux full history, so the marker on each commit is honored. Runningcargo xtask changelog checkagainst a fully cloned merge commit passes locally.Link to Devin session: https://app.devin.ai/sessions/5ecf0b837a944cb8b2db4b96a02cdee3
Open in Devin Desktop: https://app.devin.ai/desktop/session/5ecf0b837a944cb8b2db4b96a02cdee3?variant=devin
Requested by: @Orinks