Repository navigation
Follow-ups to CodeRabbit notes on #567 and #541 - #568
Merged
Merged
Conversation
The HRV catalogue blurb named the 5-minute-window mean, but nights derived before algo 110 with their raw pruned keep the older estimator's value. The blurb now names RMSSD during sleep, and the method sheet says older nights keep the value they were first given. A refused Oura command write said the ring had to be nearby and free of other apps, which the refusal does not establish. It now says the command could not be sent and asks for a retry (new key devicesOuraWriteRefused, translated in all six locales).
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis copy-only follow-up clarifies the HRV method and historical-value behavior in user-facing documentation, and distinguishes refused Oura writes from generic ring connectivity failures with localized messaging. Derived outputs and algorithm versioning are unchanged; the full suite passes except for the pre-existing health_workout_export_delete_gate_test failure. Sequence diagram for refused Oura sync write messagingsequenceDiagram
participant User
participant DevicesScreen
participant OuraSync
User->>DevicesScreen: _syncRing(c, family)
DevicesScreen->>OuraSync: sync ring
OuraSync-->>DevicesScreen: OuraSyncCategory.writeRefused
DevicesScreen-->>User: devicesOuraWriteRefused
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Follow-ups for the CodeRabbit minor notes left on #567 (v110) and #541 (Oura sync).
Copy only: no derived-output change, no kAlgoVersion bump. Full suite passes apart from the pre-existing health_workout_export_delete_gate_test failure.
🤖 Generated with Claude Code
Summary by Sourcery
Clarify HRV descriptions and distinguish refused Oura writes from general ring connectivity failures.
Bug Fixes:
Enhancements:
PR Type
Enhancement
Description
Updates the HRV catalogue blurb to describe RMSSD of beat-to-beat intervals during sleep.
Clarifies in the HRV method sheet that older nights retain values from earlier calculation methods.
Adds a specific error message (
devicesOuraWriteRefused) for Oura ring write refusals, replacing a generic connectivity error.Updates translations across six locales for the new error message and HRV blurb.
Explicit callouts: No analytics output changes occurred, and
kAlgoVersionwas not bumped. The PR changes error message behavior but adds no new tests undertest/.File Walkthrough
1 files
Map Oura write refusal to specific error message7 files
Update HRV catalogue descriptionUpdate German translations for HRV and Oura errorsUpdate English translations for HRV and Oura errorsUpdate Spanish translations for HRV and Oura errorsUpdate French translations for HRV and Oura errorsUpdate Hindi translations for HRV and Oura errorsUpdate Chinese translations for HRV and Oura errors1 files
Clarify legacy HRV value retention in method spec