Repository navigation
copy: describe the HRV headline and hrv_cv as computed - #553
Merged
Merged
Conversation
Three descriptions said something the code does not do: - The HRV method text said "RMSSD over the longest artefact-free window during sleep … corrected by the Lipponen–Tarvainen method". The nightly headline is the MEAN of RMSSD across the sleep session's 5-minute windows that hold at least 20 clean successive differences, cleaned by a 300–2000 ms range filter and a 20 % local-median ectopic filter, not by correctRr; on a night whose beat timing looks noisy only windows that pass the jitter check on their own, or sit on a steady breathing line, count; and a window or night whose beats add up to more time than passed is left out. Citation: Task Force 1996, with the ectopic filter credited as after Malik (it compares each beat to its neighbours' median, not to the previous beat). - The Health catalogue blurb said "RMSSD over the cleanest window of sleep": now "Mean RMSSD across the night's 5-minute windows". - hrv_cv was labelled "night-to-night coefficient of variation of RMSSD" / "how much that swings from night to night". It is computed WITHIN one night: SDNN of the night's Lipponen–Tarvainen-corrected beat intervals as a percentage of their mean. The chart shows how that per-night figure moves across nights, which is now what the method says, and the blurb reads "SDNN as a share of the average beat interval, within one night". Blurbs updated in all six locales (en, de, es, fr, hi, zh), with the en @descriptions to match. Copy only: no stored output changes, no kAlgoVersion bump. The 20-difference floor and the over-count rule are the analytics window-floor and RR over-count changes, and the single nightly estimator is the companion edge change; this text should land with or after them. A real night-to-night HRV CV would change a stored series' meaning and is left for separate work.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideCopy-only PR aligning HRV and hrv_cv method sheets, catalogue blurbs, citations, and localized descriptions with the current analytics and edge computations; it does not change outputs or versions. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: three descriptions said something the code does not do.
Blurbs updated in all six locales. Copy only: no output change, no bump.
User-visible before → after: the method sheets and catalogue blurbs above.
Depends on: analytics OpenStrap/analytics#88/OpenStrap/analytics#89 (the 20-difference floor and the over-count rule) and edge #552 (single estimator). It should land with or after them and the repin.
🤖 Generated with Claude Code
Summary by Sourcery
Align localized HRV metric copy with the current analytics definitions without changing outputs.
Bug Fixes:
Enhancements:
Documentation: