Skip to content

Add SQL error tests and fix plausibleGender concept handling #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katy-sadowski merged 2 commits into from
Aug 9, 2026
Merged

Add SQL error tests and fix plausibleGender concept handling #679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1360a8d
Add tests for SQL errors on Eunomia
maheshchilukamari Jul 31, 2026
fea8f44
Fix plausibleGender SQL for multiple concept IDs
maheshchilukamari Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions inst/sql/sql_server/concept_plausible_gender.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ FROM
ON cdmTable.person_id = c.subject_id
AND c.cohort_definition_id = @cohortDefinitionId
}
WHERE cdmTable.@cdmFieldName = @conceptId
WHERE cdmTable.@cdmFieldName IN (@conceptId)
AND p.gender_concept_id <> {@plausibleGender == 'Male'} ? {8507} : {8532}
/*violatedRowsEnd*/
) violated_rows
Expand All @@ -54,6 +54,6 @@ FROM
ON cdmTable.person_id = c.subject_id
AND c.cohort_definition_id = @cohortDefinitionId
}
WHERE @cdmFieldName = @conceptId
WHERE @cdmFieldName IN (@conceptId)
) denominator
;
9 changes: 9 additions & 0 deletions tests/testthat/test-executeDqChecks.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ test_that("Execute all TABLE checks on Synthea/Eunomia", {
)

expect_true(nrow(results$CheckResults) > 0)

sqlErrors <- stats::na.omit(results$CheckResults$error)
expect_length(sqlErrors, 0)
})

test_that("Execute FIELD checks on Synthea/Eunomia", {
Expand All @@ -73,6 +76,9 @@ test_that("Execute FIELD checks on Synthea/Eunomia", {
}
)
expect_true(nrow(results$CheckResults) > 0)

sqlErrors <- stats::na.omit(results$CheckResults$error)
expect_length(sqlErrors, 0)
})

test_that("Execute CONCEPT checks on Synthea/Eunomia", {
Expand Down Expand Up @@ -101,6 +107,9 @@ test_that("Execute CONCEPT checks on Synthea/Eunomia", {
}
)
expect_true(nrow(results$CheckResults) > 0)

sqlErrors <- stats::na.omit(results$CheckResults$error)
expect_length(sqlErrors, 0)
})

test_that("Execute observation period overlap check", {
Expand Down
Loading