Skip to content

Add SQL error tests and fix plausibleGender concept handling - #679

Merged
katy-sadowski merged 2 commits into
OHDSI:developfrom
maheshchilukamari:issue-605-test-sql-errors
Aug 9, 2026
Merged

Add SQL error tests and fix plausibleGender concept handling#679
katy-sadowski merged 2 commits into
OHDSI:developfrom
maheshchilukamari:issue-605-test-sql-errors

Conversation

@maheshchilukamari

@maheshchilukamari maheshchilukamari commented Aug 1, 2026

Copy link
Copy Markdown

Closes #605

Summary

Adds test coverage to verify that TABLE, FIELD, and CONCEPT checks
executed against Eunomia do not return SQL errors.

The new CONCEPT assertion exposed an existing SQLite syntax error in the
plausibleGender check when multiple concept IDs were supplied.

Changes

  • Added assertions checking results$CheckResults$error for TABLE,
    FIELD, and CONCEPT Eunomia tests
  • Updated the plausibleGender SQL predicates from = @conceptId
    to IN (@conceptId) to support multiple concept IDs

Testing

  • Ran testthat::test_file("tests/testthat/test-executeDqChecks.R")
    • FAIL 0 | WARN 0 | SKIP 2 | PASS 37

@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.13%. Comparing base (490758b) to head (fea8f44).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #679      +/-   ##
===========================================
- Coverage    87.15%   86.13%   -1.02%     
===========================================
  Files           17       17              
  Lines         1082     1082              
===========================================
- Hits           943      932      -11     
- Misses         139      150      +11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@katy-sadowski
katy-sadowski merged commit a8231d5 into OHDSI:develop Aug 9, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants