Add SQL error tests and fix plausibleGender concept handling - #679
Merged
katy-sadowski merged 2 commits intoAug 9, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #679 +/- ##
===========================================
- Coverage 87.15% 86.13% -1.02%
===========================================
Files 17 17
Lines 1082 1082
===========================================
- Hits 943 932 -11
- Misses 139 150 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #605
Summary
Adds test coverage to verify that TABLE, FIELD, and CONCEPT checks
executed against Eunomia do not return SQL errors.
The new CONCEPT assertion exposed an existing SQLite syntax error in the
plausibleGendercheck when multiple concept IDs were supplied.Changes
results$CheckResults$errorfor TABLE,FIELD, and CONCEPT Eunomia tests
plausibleGenderSQL predicates from= @conceptIdto
IN (@conceptId)to support multiple concept IDsTesting
testthat::test_file("tests/testthat/test-executeDqChecks.R")FAIL 0 | WARN 0 | SKIP 2 | PASS 37