Repository navigation
Group each repl route's files in app/routes/<name>/ - #2248
Merged
Merged
Conversation
|
|
Contributor
Footnotes
|
Port the layout from url-shortener (branch stripe). Each route folder holds +route.ts, +template.gts, and +controller.ts, plus the components and styles that only that route uses. app/custom-layout.ts translates those paths to the classic resolver keys, and builds the lazy docs bundles from a glob instead of a hand-written list. The application controller (query params) moves to +controller.ts in the application route folder. import-map.ts was not a route, so it moves beside the application route that uses it. The page-title service becomes a re-export so services can be globbed like the other modules. vite-ember-ssr keys its CSS manifest by an app/templates/<route>.gts path and falls back to the chunk name, which is `_template` for every route here. That dropped the docs stylesheet link from the prerendered docs pages. config/route-css-manifest.js rewrites the manifest per route before the prerender step reads it. The prerendered output now matches main. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The docs routes are plain templates with no route class, controller, or route-only components, so the folder layout buys them nothing. They go back to app/templates/docs/, and the router lists their lazy bundles by hand again. That also puts their templates where vite-ember-ssr expects them, so the prerendered docs pages get their stylesheet link without the manifest rewrite plugin. The plugin is gone. The general fix, so any layout works, is proposed upstream in evoactivity/vite-ember-ssr#24. The save banner, the current-url helper, and the constrain-vertically modifier are only used by the edit route, so they move next to their users. The is-editing, not, and stringify helpers and the positioned-n-lines-from-top modifier had no importers, so they are deleted. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…rt file app-ssr.ts already registers it that way. A file whose only job is to be found by the services glob is not worth having. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
NullVoxPopuli-ai-agent
force-pushed
the
nvp/repl-route-layout
branch
from
October 12, 2026 22:03
737f546 to
551aeec
Compare
NullVoxPopuli
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the route folder layout from url-shortener (branch
stripe) intoapps/repl.Layout
Each route lives in
app/routes/<name>/:+route.ts,+template.gts, and+controller.ts(only for routes with query params)app/routes/edit/header.gts,app/routes/edit/save.gts, andapp/routes/edit/layout/constrain-vertically.tsapp/custom-layout.tsmaps those paths to the resolver keys (./routes/x,./templates/x,./controllers/x).The docs routes are plain templates with nothing to co-locate, so they stay in
app/templates/docs/and the router keeps listing their lazy bundles by hand.Other moves:
app/routes/application/+controller.tsimport-map.tswas not a route, so it moved beside the application route that uses it#edit/*now points atapp/routes/edit/*is-editing,not, andstringifyhelpers and thepositioned-n-lines-from-topmodifier had no importers and are deletedWhat stays in
app/components/andapp/modifiers/is shared by more than one route, or is a public name for demos (limber/components/menu).Prerendered CSS
vite-ember-ssrkeys its CSS manifest by anapp/templates/<route>.gtspath. With the docs templates left there, the prerendered docs pages link the same stylesheets as a clean build ofmain. A layout independent fix is proposed upstream in evoactivity/vite-ember-ssr#24 (issue #23).Checks
pnpm lint:typespassespnpm test:chromepasses (54 tests, 7 skipped)🤖 Generated with Claude Code