Repository navigation
Move the docs routes to app/routes/docs/ - #2292
Merged
Merged
Conversation
The CSS manifest of vite-ember-ssr names a lazy route from its app/templates/<route>.gts path. A route template in another folder gets the chunk name as its key, so its prerendered page has no stylesheet link. The patch adds a routeName(modulePath) option to emberSsr and emberSsg. It runs at build time, when the plugin writes the manifest. Upstream issue: evoactivity/vite-ember-ssr#23 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each docs route now has app/routes/docs/<name>/+template.gts, like the other routes. The docs stay out of the eager glob in app.ts, and the router still loads each one as a lazy bundle. The SSG build gets the route name of each template through the routeName option, so the prerendered pages keep their stylesheet links. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs routes now use the same layout as the other routes:
app/routes/docs/<name>/+template.gts. Follow-up to #2248.The docs stay lazy. The glob in
app/app.tsdoes not list them, andapp/router.tsloads each one as its own bundle.Changes
vite-ember-ssrmoves from 0.6.0 to 0.6.2, with a pnpm patch.routeName(modulePath)option toemberSsrandemberSsg.apps/repl/vite.config.jspasses theroutes/<name>/+template.gtsrule through that option.app/templates/docs/toapp/routes/docs/.app/app-ssr.tsloads the docs templates throughcustomLayout.Why the patch
vite-ember-ssrnames a lazy route in its CSS manifest from the pathapp/templates/<route>.gts. In another folder, the key is the chunk name, and the prerendered page loses its stylesheet link.The option runs at build time, when the plugin writes the manifest. The render step does not change.
Upstream issue: evoactivity/vite-ember-ssr#23. The patch can go when upstream has a fix.
Checks
pnpm turbo build:prod --filter=limberpasses.dist/css-manifest.jsonhas the keysdocs,docs.index,docs.editor,docs.embedding,docs.ember-repl,docs.repl-sdk, anddocs.related.pnpm lintpasses inapps/repl.apps/replpass: 73 pass, 7 skip, 0 fail.🤖 Generated with Claude Code