A fetched list's size cap of 0 (no limit) is enforced as a literal zero-byte ceiling (#937) - #938
Merged
Ninja-FSE merged 1 commit intoSep 24, 2026
Conversation
…ro-byte ceiling (#937) dcc_fetch.py's admission check already treats MAX_FETCH_LIST_FILE_SIZE = 0 as no limit (#302), but list_fetch.py's belt-and-braces on-disk-size check, run after a successful download and before the zip is opened, compared the raw value: with the setting at 0, any real file's size is "more than" 0, so every fetched list was rejected right after downloading it - reproduced live: a 19,916,132-byte zip refused with the setting explicitly at 0. Fix: the same list_zip_cap > 0 guard dcc_fetch.py already uses. tests/test_list_fetch.py: test_zero_means_no_cap_here_too, mutation-checked against the exact reported failure (fails without the fix, with the same message the operator saw).
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #937.
dcc_fetch.py's admission check already treatsMAX_FETCH_LIST_FILE_SIZE = 0as no limit (#302), butlist_fetch.py's belt-and-braces on-disk-size check - run after a successful download, before the zip is opened - compared the raw value: with the setting at 0, any real file's size is "more than" 0, so every fetched list was rejected right after downloading it.Reproduced live on the operator's own bot: a 19,916,132-byte zip refused with
MAX_FETCH_LIST_FILE_SIZE (0) - refusing to open it, the setting explicitly set to 0 in the dashboard expecting "no limit".Fix: the same
list_zip_cap > 0guarddcc_fetch.pyalready uses.Test:
test_zero_means_no_cap_here_toointests/test_list_fetch.py. Mutation-checked - fails without the fix, with the exact message the operator saw.Full suite 6693 OK.
🤖 Generated with Claude Code