Skip to content

MAX_FETCH_FILE_SIZE = 0 (no limit) trips the list zip-bomb guard too #939

Description

@Ninja-FSE

Sibling of #937/#938, found immediately after that fix shipped.

list_fetch.py reads MAX_FETCH_FILE_SIZE twice - once as the zip-bomb guard on a fetched list's declared total uncompressed size (_validate_zip_members()), once as the running extraction budget (process_fetched_list_zip()) - and neither read treated 0 as "no limit" the way dcc_fetch.py's own admission check does (#302).

Reproduced live right after #938 shipped:

[LIST-FETCH] Rejected list zip from SamothMetal: zip's declared total uncompressed size exceeds MAX_FETCH_FILE_SIZE (0 bytes) - refusing to extract (zip-bomb guard)

with MAX_FETCH_FILE_SIZE explicitly at 0 in the dashboard, expecting "no limit".

🤖 Filed with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions