Skip to content

Use latest rattler-build for conda packaging - #2859

Merged
rapids-bot[bot] merged 9 commits into
NVIDIA:mainfrom
vyasr:rattler-build-latest
Oct 15, 2026
Merged

rapids-bot[bot] merged 9 commits into
NVIDIA:mainfrom
vyasr:rattler-build-latest

Conversation

@vyasr

@vyasr vyasr commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Install and verify the latest stable conda-forge rattler-build before C++ and Python conda packaging, allowing cuVS to migrate independently of the shared CI image pin.

The explicit installation of the latest stable rattler-build version in the build scripts is temporary. The installer and its calls will be removed as soon as the shared RAPIDS CI images are updated to provide the upgraded version.

Replace the libcuvs recipe cache with a staging output while preserving all package splits. Explicitly forward the CUDA version, benchmark architecture, and sccache configuration required by isolated build scripts, including the CPU benchmark. Declare direct native library owners for split outputs and CPU benchmarks while preserving their existing dependency contracts.

Related to rapidsai/build-planning#259.

@vyasr vyasr added improvement Improves an existing functionality non-breaking Introduces a non-breaking change ci labels Oct 14, 2026
@copy-pr-bot

copy-pr-bot Bot commented Oct 14, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@vyasr

vyasr commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@vyasr

vyasr commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Oct 14, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vyasr

vyasr commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Oct 15, 2026

Copy link
Copy Markdown

/ok to test

@vyasr, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@vyasr

vyasr commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 17a29f3

@vyasr

vyasr commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test d48d7f7

@copy-pr-bot

copy-pr-bot Bot commented Oct 15, 2026

Copy link
Copy Markdown

/ok to test d48d7f7

@vyasr, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@vyasr

vyasr commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test d48d7f7

@vyasr

vyasr commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 29ce9f7

@vyasr

vyasr commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 0cb4ba2

@vyasr

vyasr commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 64c97b9

@vyasr

vyasr commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test d5a90f0

@vyasr
vyasr force-pushed the rattler-build-latest branch from d5a90f0 to 4725f9e Compare October 15, 2026 04:45
@vyasr

vyasr commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 4725f9e

Signed-off-by: Vyas Ramasubramani <vyasr@nvidia.com>
@vyasr

vyasr commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 442f2e9

@vyasr
vyasr marked this pull request as ready for review October 15, 2026 20:12
@vyasr
vyasr requested review from a team as code owners October 15, 2026 20:12
@vyasr
vyasr requested a review from jameslamb October 15, 2026 20:12
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/cuvs/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: ba948f93-07ec-47d9-8d54-0b7bc098ad9f
📥 Commits

Reviewing files that changed from the base of the PR and between 1ff52f0 and 442f2e9.

📒 Files selected for processing: 6
  • ci/build_cpp.sh
  • ci/build_python.sh
  • ci/install_rattler_build.sh
  • conda/recipes/cuvs-bench-cpu/recipe.yaml
  • conda/recipes/cuvs/recipe.yaml
  • conda/recipes/libcuvs/recipe.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated C++ and Python build setup to use the latest stable build tool and verify the installed version.
    • Refined package build settings to pass through CUDA and cache configuration.
    • Updated runtime dependencies for CPU benchmarks, shared libraries, tests, examples, and ANN benchmarks, including platform-specific dependencies for Linux and ARM systems.

The CI build scripts now install and verify rattler-build. The Conda recipes update build environment values, define a shared libcuvs staging output, and add runtime dependencies to benchmark and package outputs.

Changes: Build and packaging

Layer / File(s) Summary
Install and verify rattler-build
ci/install_rattler_build.sh, ci/build_cpp.sh, ci/build_python.sh
A new script selects the latest stable rattler-build version, installs it, and checks the installed version. Both CI build scripts source the script.
Recipe environments and CPU benchmark requirements
conda/recipes/cuvs/recipe.yaml, conda/recipes/cuvs-bench-cpu/recipe.yaml
The recipes forward additional build environment values. The CPU benchmark recipe adds runtime dependencies, including platform-specific dependencies.
Stage shared libcuvs build configuration
conda/recipes/libcuvs/recipe.yaml
The recipe moves shared build settings and requirements into libcuvs-build. The headers, library, tests, examples, and ANN benchmark outputs inherit the staging configuration.
Set libcuvs output runtime requirements
conda/recipes/libcuvs/recipe.yaml
The libcuvs, tests, examples, and ANN benchmark outputs add runtime dependencies. The ANN benchmark sets RAPIDS_CONDA_ARCH and adds architecture- and platform-specific dependencies.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 442f2

No actionable merge-blocking risk is established; the change is mergeable after normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly summarizes the primary change: using the latest stable rattler-build for conda packaging.
Description check Passed The description accurately covers rattler-build installation and verification, recipe staging changes, environment forwarding, dependency ownership, and the related issue.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@vyasr

vyasr commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit facd61d into NVIDIA:main Oct 15, 2026
221 of 224 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in Unstructured Data Processing Oct 15, 2026
@vyasr
vyasr deleted the rattler-build-latest branch October 15, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants