Skip to content

Remove temporary rattler-build installer - #2868

Open
vyasr wants to merge 1 commit into
NVIDIA:mainfrom
vyasr:remove-rattler-installer
Open

vyasr wants to merge 1 commit into
NVIDIA:mainfrom
vyasr:remove-rattler-installer

Conversation

@vyasr

@vyasr vyasr commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Remove the temporary rattler-build installer added in #2859 and its calls from the conda build scripts, so builds use the rattler-build provided by the CI image.

Depends on rapidsai/ci-imgs#473. Keep this PR in draft until that image update has merged and the updated images are available.

Related to rapidsai/build-planning#259.

Signed-off-by: Vyas Ramasubramani <vyasr@nvidia.com>
@vyasr vyasr added improvement Improves an existing functionality non-breaking Introduces a non-breaking change ci labels Oct 16, 2026
@copy-pr-bot

copy-pr-bot Bot commented Oct 16, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@bdice
bdice marked this pull request as ready for review October 16, 2026 05:27
@bdice
bdice requested a review from a team as a code owner October 16, 2026 05:27
@bdice
bdice self-requested a review October 16, 2026 05:27
@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/cuvs/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: f168ea26-ebc2-43d6-be8d-e778f41fa46c
📥 Commits

Reviewing files that changed from the base of the PR and between facd61d and 2ac5ba0.

📒 Files selected for processing: 3
  • ci/build_cpp.sh
  • ci/build_python.sh
  • ci/install_rattler_build.sh
💤 Files with no reviewable changes: 3
  • ci/build_cpp.sh
  • ci/install_rattler_build.sh
  • ci/build_python.sh

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Removed the separate step that selected and installed a specific build-tool version in the C++ and Python build workflows. The remaining build setup and commands are unchanged, so this update does not change the documented build behavior.

The C++ and Python CI build scripts no longer source install_rattler_build.sh. The installer script, which selected and installed a stable rattler-build version and verified the installed version, is removed.

Changes: CI build setup

Layer / File(s) Summary
Remove rattler-build installation
ci/install_rattler_build.sh, ci/build_cpp.sh, ci/build_python.sh
The build scripts no longer source the installer. The installer’s version selection, installation, and version verification commands are removed.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 2ac5b

The build scripts now rely on the CI image for rattler-build. Confirm the updated image is available before merging; no concrete build failure is established.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: removing the temporary rattler-build installer.
Description check Passed The description directly explains the installer removal, the build-script updates, the CI image dependency, and the draft requirement.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

2 participants