Skip to content

Fix stale data generation comment in generate_input.hpp #23816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VaggelisGian wants to merge 3 commits into
base: main
Choose a base branch
from
+1 −2
Open

Fix stale data generation comment in generate_input.hpp #23816

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1b2d27
benchmarks: correct stale data generation comment in generate_input.hpp
VaggelisGian Aug 23, 2026
5b3d82d
Update cpp/benchmarks/common/generate_input.hpp
PointKernel Aug 25, 2026
14e9365
Merge branch 'main' into docs-generate-input-device-comment
PointKernel Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cpp/benchmarks/common/generate_input.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@
* The create_random_table functions take a data profile, the information about table size and a
* seed to deterministically generate a table with given parameters.
*
* Currently, the data generation is done on the CPU and the data is then copied to the device
* memory.
* The input data generation happens on device.
*/

/**
Expand Down
Loading