Fix stale data generation comment in generate_input.hpp - #23816
Fix stale data generation comment in generate_input.hpp#23816VaggelisGian wants to merge 3 commits into
Conversation
The file comment claimed input generation happens on the CPU before being copied to device memory. The implementation fills rmm::device_uvectors with thrust::tabulate on the device execution policy, so generation runs on the device, which is also what the developer guide's benchmarking page already documents. The comment predates the device-side generator introduced in NVIDIA#10109 and was never updated. Test Plan: Comment-only change; no code or build impact.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe benchmark documentation retains the statement that input generation occurs on the device and removes the comparison with host-side ChangesBenchmark input generation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change only corrects an outdated benchmark comment and does not alter code paths or runtime behavior; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
PointKernel
left a comment
There was a problem hiding this comment.
Thanks for catching this.
Co-authored-by: David Wendt <45795991+davidwendt@users.noreply.github.com>
|
/ok to test 5b3d82d |
|
/ok to test 14e9365 |
Description
The file-level comment in
cpp/benchmarks/common/generate_input.hppclaimed that random data generation happens on the CPU and is then copied to device memory. The implementation actually fills device buffers directly on the GPU (thrust::tabulateover the device policy ingenerate_input.cu), anddocs/benchmarking.mdalready documents device-side generation. This corrects the stale comment so it matches the actual behavior.Comment-only change: no code paths, build targets, or runtime behavior are affected.
Checklist