Skip to content

test: make the Codex MCP login timeout test independent of runner speed #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AjayThorve merged 2 commits into from
Oct 16, 2026
Merged

test: make the Codex MCP login timeout test independent of runner speed #427

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0273821
test: widen the Codex MCP login timeout margin
mnajafian-nv Oct 16, 2026
40de8f4
test: give the Codex MCP login test an exact remaining budget
mnajafian-nv Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/adapters/test_codex_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,6 +888,9 @@ def test_codex_logs_into_mcp_server_before_first_turn(
mock_codex.mcp_auth_statuses["remote"] = adapter.McpAuthStatus.not_logged_in
open_browser = AsyncMock(return_value=True)
monkeypatch.setattr(adapter, "_open_authorization_url", open_browser)
# Give the login an exact remaining budget, so the rounding check does not
# depend on how long the runner takes before the adapter reads the clock.
monkeypatch.setattr(adapter, "_remaining_timeout", lambda _: invocation_timeout)

output = invoke_once(codex_payload)

Expand Down
Loading