fix(webxr): align input replays across XR sessions - #1063
Draft
yanziz-nvidia wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Yanzi Zhu <yanziz@nvidia.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Client-side input recordings are stored in the active R3F scene reference space. A new XR session may establish a different origin even when both sessions use the same reference-space type, so replaying the stored coordinates directly can shift the hand trajectory.
This change:
Calibration assumption: the headset must be at the same physical calibration pose at recording start and when replay first starts in a new XR session. Without a shared world marker or tracked table pose, the client cannot distinguish origin drift from the operator physically moving the headset.
Type of change
Testing
npm test -- --runInBand— 7 suites, 109 tests passednpm test -- --runInBand src/xrInputRecorder.test.ts— 36 tests passedSKIP=check-copyright-year pre-commit run --all-files— passedChecklist
SKIP=check-copyright-year pre-commit run --all-filesgit commit -s) per the DCO