fix(web): prevent scrolling from changing server port - #1052
Conversation
Signed-off-by: Yanzi Zhu <yanziz@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe WebXR client port field now uses Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The change prevents mouse-wheel scrolling from altering the CloudXR server port while preserving numeric keyboard hints and existing parsing and persistence behavior. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
inputmode="numeric"Validation
SKIP=check-copyright-year pre-commit run --all-filesnpm test -- --runInBand(102 tests)npm run buildnpx prettier --check src/index.htmlsrc/index.htmlwith JSDOM and verifiedportInputhastype=textandinputMode=numericSummary by CodeRabbit