Skip to content

fix(web): prevent scrolling from changing server port - #1052

Merged
yanziz-nvidia merged 1 commit into
mainfrom
fix/web-client-port-text-input
Aug 29, 2026
Merged

fix(web): prevent scrolling from changing server port#1052
yanziz-nvidia merged 1 commit into
mainfrom
fix/web-client-port-text-input

Conversation

@yanziz-nvidia

@yanziz-nvidia yanziz-nvidia commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • render the CloudXR server port as a text field so mouse-wheel scrolling cannot step and persist a different port
  • retain the numeric virtual keyboard hint with inputmode="numeric"
  • keep existing port parsing, defaults, URL seeding, and local-storage persistence unchanged

Validation

  • SKIP=check-copyright-year pre-commit run --all-files
  • npm test -- --runInBand (102 tests)
  • npm run build
  • npx prettier --check src/index.html
  • parsed src/index.html with JSDOM and verified portInput has type=text and inputMode=numeric

Summary by CodeRabbit

  • Bug Fixes
    • Updated the port field to provide a numeric keyboard on supported devices.
    • Removed restrictive built-in minimum and maximum value limits.

Signed-off-by: Yanzi Zhu <yanziz@nvidia.com>
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 044bbf30-cde7-4e2a-b757-77b3be25ea17

📥 Commits

Reviewing files that changed from the base of the PR and between 993a46e and cd8a0ae.

📒 Files selected for processing (1)
  • deps/cloudxr/webxr_client/src/index.html

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The WebXR client port field now uses type="text" with inputmode="numeric". The change removes the native min and max constraints.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to cd8a0

The change prevents mouse-wheel scrolling from altering the CloudXR server port while preserving numeric keyboard hints and existing parsing and persistence behavior. No actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: preventing scrolling from changing the server port.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/web-client-port-text-input

Comment @coderabbitai help to get the list of available commands.

@yanziz-nvidia
yanziz-nvidia merged commit 9fba23c into main Aug 29, 2026
65 of 72 checks passed
@yanziz-nvidia
yanziz-nvidia deleted the fix/web-client-port-text-input branch August 29, 2026 03:34
github-actions Bot added a commit that referenced this pull request Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants