examples(teleop_ros2): package under isaacteleop_examples - #1039
Open
jiwenc-nv wants to merge 1 commit into
Open
examples(teleop_ros2): package under isaacteleop_examples#1039jiwenc-nv wants to merge 1 commit into
jiwenc-nv wants to merge 1 commit into
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
jiwenc-nv
force-pushed
the
jiwenc-nv/examples-teleop-ros2
branch
from
August 28, 2026 05:00
9b577b0 to
008c2a4
Compare
jiwenc-nv
changed the base branch from
jiwenc-nv/examples-deviceio-live-view
to
jiwenc-nv/examples-mcap-record-replay
August 28, 2026 05:01
9 tasks
jiwenc-nv
force-pushed
the
jiwenc-nv/examples-teleop-ros2
branch
from
August 28, 2026 05:22
008c2a4 to
b71f0e1
Compare
jiwenc-nv
force-pushed
the
jiwenc-nv/examples-teleop-ros2
branch
from
August 28, 2026 05:32
b71f0e1 to
a212d0a
Compare
jiwenc-nv
force-pushed
the
jiwenc-nv/examples-teleop-ros2
branch
from
August 28, 2026 05:44
a212d0a to
56ba82a
Compare
sgrizan-nv
approved these changes
Aug 28, 2026
jiwenc-nv
force-pushed
the
jiwenc-nv/examples-teleop-ros2
branch
2 times, most recently
from
August 28, 2026 14:46
ae449ca to
8d2a267
Compare
jiwenc-nv
force-pushed
the
jiwenc-nv/examples-teleop-ros2
branch
from
August 28, 2026 16:10
8d2a267 to
d5b5fee
Compare
jiwenc-nv
force-pushed
the
jiwenc-nv/examples-teleop-ros2
branch
2 times, most recently
from
August 29, 2026 00:21
1d6e024 to
9c120d4
Compare
Fifteen modules imported their siblings as top-level modules -- constants, messages, geometry, assets, session_config and the rest -- which resolved only because the invoked script's own directory landed on sys.path. That broke under `python -m`, broke when copied into another project, and claimed a set of unusually generic names. Move the tree to the layout in examples/README.md. Two workarounds propping this up are now gone, which is the evidence the packaging is real rather than relocated: `pythonpath = ["."]` in the pyproject, and the example source directory on the ctest PYTHONPATH. The tests reach the in-tree source through a conftest.py instead, mirroring mujoco_xr's, so a bare `pytest` in that directory works for the first time. The node keeps its filename and gains a __main__.py, so the container entry point becomes `python -m isaacteleop_examples.teleop_ros2` and still forwards --ros-args. The install tree drops a level, so the Dockerfile WORKDIR follows. Part of #985. Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
jiwenc-nv
force-pushed
the
jiwenc-nv/examples-teleop-ros2
branch
from
August 29, 2026 01:19
9c120d4 to
24146a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #985. Stacked on #1038.
Fifteen modules imported their siblings as top-level modules —
constants,messages,geometry,assets,session_configand the rest — which resolved only because the invoked script's own directory landed onsys.path. That broke underpython -m, broke when copied into another project, and claimed an unusually generic set of names. This moves the tree to the layout inexamples/README.md.Two workarounds propping this up are deleted, which is the evidence the packaging is real rather than relocated:
pythonpath = ["."]in the pyprojectPYTHONPATHThe tests reach the in-tree source through a
conftest.pyinstead, mirroringmujoco_xr's, so a barepytestin that directory works for the first time. Six test import lines change; no assertion does.The node keeps its filename and gains a
__main__.py, so the container entry point becomespython -m isaacteleop_examples.teleop_ros2and still forwards--ros-args. The install tree drops a level, so the DockerfileWORKDIRfollows, as do the three invocations inbuild-ubuntu.yml.Type of change
Testing
x86_64/ Ubuntu, Python 3.12. Wheel ships 15 modules underisaacteleop_examples/teleop_ros2/with no namespace__init__.py. Editable-installed into a clean venv, the ROS-free modules (constants,tensor_group_helpers) import with the CWD outside the repo;import constantsfails, so the flat names are gone rather than relocated. The newconftest.pywas checked to resolve toexamples/teleop_ros2/pythonwith the package present and no namespace__init__.py. All test files compile.pre-commitclean.Not run:
ctest -L teleop_ros2— no ROS 2 on this host, sogeometry_msgsandrclpyare unavailable. That suite and the container entry point are what CI should be trusted for here; please treat the CI run as the gate rather than my local checks.Checklist
SKIP=check-copyright-year pre-commit run --all-filesgit commit -s) per the DCONo new tests: this is a move. The existing suite is the check — it exercises every moved module and passes with only its import lines changed.