Repository navigation
Fix schema-2 result storage provenance and provide safe repair - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful shallow imports lost storage provenance because the reader expected top-level
imagesand nested source records. Parse the actual schema-2 graph/binding contract withShallowManifest, select the correct Image node, and preserve workflow, managed-path, receipt and ambiguity checks. Full-Zarr handling remains independent of shallow feature flags.Partial metadata now produces an explicit
WARNINGin the import script'sMessagewhile keeping imported data available. Storage evidence is persisted before rendering workflow maps.Add an administrator-only, dry-run-by-default backfill that reads existing managed evidence and records it once, refusing conflicting history. Expose an explicit storage-repair option through the existing metadata persistence adapter, retaining its backups and shared-annotation protections. The README documents both steps. Pixel arrays are never read or rewritten by repair.
Closes #41.
Validation: 293 passed, 4 existing skips across the complete separate harness, plus script compilation and
git diff --check. Initial schema-2 regression run: 23 failed / 6 guards passed; the additional repair-adapter and conflicting-evidence tests also failed before their fixes. Real schema-2 fixtures cover Image/Plate bindings, both interchange profiles, invalid manifests/references, warnings, persistence order and idempotent repair. Live OMERO/ACC acceptance remains to be run after deployment.Dependencies and merge order:
test-suitemust merge first, then rerun this PR's CI. The current canonical harness uses schema 0.2 and invalid legacy shallow fixtures, so it cannot validate this fixed reader. The updated harness also passes unchanged master: 261 passed, 36 skipped, with new behavior capability-gated.Kept in draft until the canonical harness prerequisite is merged. No tests are included in the deployable branch; no release or data repair was performed.