Remove original proprietary input format

[grantfirl]

SOURCE: @grantfirl CIRA

DESCRIPTION OF CHANGES:

• Builds off of Use 2 timelevels for SCM state variables and remove the leapfrog scheme code #717
• Removes all code related to reading in the original input format; removes any reference to the original input format

ISSUE: N/A

ASSOCIATED PRs:
This should get merged after #717

TESTS CONDUCTED: SCM RTs

REGRESSION TEST CHANGES: None expected over and above #717

[scrasmussen]

Things look good to me! Though, I think one thing that will need to be changed is also removing input_type = 1 from the dephy_converter.py, line 2465?

The mod_forcing.py script also still has input_type statements. Is this script still useful? If so it should probably be cleaned up, if not it could be deleted.

[hertneky]

@grantfirl Changes look good. Just a handful of comments on possible additional changes.
Builds - check!
Runs SCM RTs - check!

[grantfirl]

Things look good to me! Though, I think one thing that will need to be changed is also removing input_type = 1 from the dephy_converter.py, line 2465?

The mod_forcing.py script also still has input_type statements. Is this script still useful? If so it should probably be cleaned up, if not it could be deleted.

I fixed dephy_converter.py to remove the input_type from the newly-converted case configuration files. I'm not sure if anyone is still using this script, but at least this won't be a continuing problem if someone is using this to convert old format cases out there.

I'm not really sure what to do with the mod_forcing.py script. I think I wrote this in order to add selected tendencies to the forcing terms so that a subsequent run of a case could remove one or more schemes from a SDF thereby removing interactions with the remaining physics (to more effectively isolate result changes from the remaining part of the suite). I doubt that this has ever been used since it was put in the repo, yet I'm kinda hesitant to remove it since the idea behind it could still be useful. I don't want to spend the time updating it, yet I don't want to remove it. If you guys prefer to remove it, I'll go along with it because it should be retrievable via git history if anyone ever needs it (or recreated altogether). Thoughts?

[grantfirl]

@scrasmussen This brings up a broader point about files in scm/etc/scripts. This has kinda been a dumping ground for scripts that were useful at one point but are likely non-working in various ways and are unsupported. I think that the idea of keeping them in the repo is just that "these could be useful for someone someday, even if they're broken". We've never really supported much in here besides the UFS_case_gen script. Keeping old scripts in here probably goes against good repository "hygiene", yet I still don't know whether removing them is the best thing to do or not.

[scrasmussen]

@scrasmussen This brings up a broader point about files in scm/etc/scripts. This has kinda been a dumping ground for scripts that were useful at one point but are likely non-working in various ways and are unsupported. I think that the idea of keeping them in the repo is just that "these could be useful for someone someday, even if they're broken". We've never really supported much in here besides the UFS_case_gen script. Keeping old scripts in here probably goes against good repository "hygiene", yet I still don't know whether removing them is the best thing to do or not.

@grantfirl I like the idea of moving the old scripts we don't use anymore to a new directory named scm/etc/scripts/archive, or something similar. It will serve the purpose of cleaning up the scripts directory while still keeping the scripts around for reference.

[scrasmussen]

The changes look good to me! I don't mind waiting to clean up the script directory at a later point.