Use 2 timelevels for SCM state variables and remove the leapfrog scheme code - #717
Conversation
…r updated state to main state at the end of the timestep
|
I just wanted to let you know that I tried this for the prognostic tracers I had included (updraft, area fraction), and it works. Thank you. |
@lisa-bengtsson Great! Thanks for following up. |
scrasmussen
left a comment
There was a problem hiding this comment.
Changes look good! Like the use foo, only: bar changes. Looked through a number of the CI artifact plots that the CI said differed, but couldn't see any change from the baseline.
hertneky
left a comment
There was a problem hiding this comment.
Changes look good. I made comments about removal of some leftover mentions of leapfrog in pr718 on accident - mixing up the PRS! I decided to not make the same comments here.
Tested on derecho gnu: built and ran scm rts fine.
Thanks for the review. I addressed the comments in #718 related to the removal of the leapfrog scheme in this PR. The other comment will be addressed in that PR once we merge this one and update 718. |
SOURCE: @grantfirl CIRA
DESCRIPTION OF CHANGES:
onlyto module use statements in SCM code for better readability etc.ISSUE: Fixes #184
ASSOCIATED PRs:
N/A
TESTS CONDUCTED: SCM RTs
REGRESSION TEST CHANGES: Using 2 timelevels to hold these different states causes machine-precision-level differences.